Refactor UB04 837i X12 feature to make work again. #7412
Conversation
| @@ -20,8 +20,6 @@ | |||
|
|
|||
| namespace OpenEMR\Billing\BillingProcessor; | |||
|
|
|||
| use OpenEMR\Billing\BillingProcessor\BillingClaimBatchControlNumber; | |||
There was a problem hiding this comment.
hi @sjpadgett , great work getting this going again
pretty sure need this when using it below in lines 61 and 64
There was a problem hiding this comment.
nope it's already in scope
There was a problem hiding this comment.
oh, nvm, since it's in the same namespace :)
There was a problem hiding this comment.
Also a FYI the latest ci will optimize uses and removed unused automatically so be sure to keep an eye on and verify removals yourself.
There was a problem hiding this comment.
okay for phpstorm?
There was a problem hiding this comment.
Still i'm force testing for clarity but i'm confident as it's in same namespace and is static so path is automatic.
| $ub04id[367] = $diagnosis[0] ?? '' ? substr($diagnosis[0], 0, 7) : ''; /* 69. ADMITTING DIAGNOSIS CODE */ | ||
| $ub04id[368] = $diagnosis[1] ?? '' ? substr($diagnosis[1], 0, 7) : ''; /* 70a. PATIENT'S REASON FOR VISIT */ | ||
| $ub04id[369] = $diagnosis[2] ?? '' ? substr($diagnosis[2], 0, 7) : ''; /* 70b. PATIENT'S REASON FOR VISIT */ | ||
| $ub04id[370] = $diagnosis[3] ?? '' ? substr($diagnosis[3], 0, 7) : ''; /* 70c. PATIENT'S REASON FOR VISIT */ |
|
I'm merging so I can get it out to customer to test the 837i claim X12. Hopefully I won't need to come back to this in another 7 years!:) |
* Refactor UB04 837i feature to make work again. * fix PHP 8.2 warnings (cherry picked from commit 14e7854)
Refactor UB04 837i X12 feature to make work again. (#7412)
|
|
…_last * 'master' of https://github.com/openemr/openemr: Hide dashboard card 2 (openemr#7423) fix: ccda zip import and php warnings and deprecations (openemr#7416) Fee sheet and Codes revenue code (openemr#7415) Refactor UB04 837i X12 feature to make work again. (openemr#7412) feat: support loop 2420E (openemr#7405) Fix: Revert "Fix: OpenEMR logs sensitive information such as payment details (openemr#7341)" (openemr#7396) Weno better error handling from fetches (openemr#7408)
Fixes #7413
Short description of what this resolves:
Many reverts and fixes to project.
Changes proposed in this pull request:
Fixed from issues