Fix User Admin screen Google Email for Login does not save when creating new user #7472
Conversation
AlceaDev
changed the title
| @@ -351,6 +351,7 @@ | |||
| "', mname = '" . add_escape_custom(trim((isset($_POST['mname']) ? $_POST['mname'] : ''))) . | |||
| "', lname = '" . add_escape_custom(trim((isset($_POST['lname']) ? $_POST['lname'] : ''))) . | |||
| "', suffix = '" . add_escape_custom(trim((isset($_POST['suffix']) ? $_POST['suffix'] : ''))) . | |||
| "', google_signin_email = '" . add_escape_custom(trim((isset($_POST['google_signin_email']) ? $_POST['google_signin_email'] : ''))) . | |||
There was a problem hiding this comment.
This could be written as
add_escape_custom(trim($_POST['google_signin_email'] ?? ''))
What you have is acceptable as well so, is this done?
There was a problem hiding this comment.
Thank you for your review！
That's better for me.If possible, want rewrite other same descriptions in this insert statement. Could I do this?
There was a problem hiding this comment.
Naw, I'd leave it to stay consistent with the other fields and changing all of them is probably best left as is because less of a chance to introduce an error during change.
Let me know if this is all and I'll merge and put in patch 2. Thanks for the fix!
There was a problem hiding this comment.
OK! This is all , So request to merge when you're free.
I appreciate that you gave me contributing chance！
…hanges * 'master' of https://github.com/openemr/openemr: fix: use temp files dir for htmlpurify serializer path (openemr#7476) fix: webroot typo documents-go portal home (openemr#7474) add insert value to google_signin_email column in users table (openemr#7472)
Fixes #7393
Short description of what this resolves:
Not exist insert statement for google_signin_email column in users table.
So add insert statement value to column in interface/usergroup/usergroup_admin.php.