Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to verify TCS exhaustion to address missing thread binding coverage #1023

Merged
merged 7 commits into from
Nov 8, 2018

Conversation

anitagov
Copy link
Contributor

@anitagov anitagov commented Nov 7, 2018

New thread binding test coverage to verify TCS exhaustion i.e. enter on N threads when there are M TCSes where N > M
oe_call should return OE_OUT_OF_THREADS when M enclaves are in use.
Trick is to keep the M enclaves busy until we get TCS exhaustion and run out of all the threads.
This was mentioned in Issue #24

@anitagov
Copy link
Contributor Author

anitagov commented Nov 7, 2018

@CodeMonkeyLeet CodeMonkeyLeet added the testing Issue has to do with testing or quality management label Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet added this to Backlog in Public preview via automation Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet added this to the 2018.11 milestone Nov 7, 2018
tests/thread/host/host.cpp Show resolved Hide resolved
tests/thread/oethread_enc/enc.cpp Outdated Show resolved Hide resolved
tests/thread/host/host.cpp Outdated Show resolved Hide resolved
oe-bors bot pushed a commit that referenced this pull request Nov 7, 2018
oe-bors bot pushed a commit that referenced this pull request Nov 7, 2018
oe-bors bot pushed a commit that referenced this pull request Nov 7, 2018
@anitagov
Copy link
Contributor Author

anitagov commented Nov 8, 2018

All platforms but Windows passed in sandbox mode. Retrying bors try.

@anitagov
Copy link
Contributor Author

anitagov commented Nov 8, 2018

bors try

oe-bors bot pushed a commit that referenced this pull request Nov 8, 2018
oe-bors bot pushed a commit that referenced this pull request Nov 8, 2018
@anitagov
Copy link
Contributor Author

anitagov commented Nov 8, 2018

bors try

oe-bors bot pushed a commit that referenced this pull request Nov 8, 2018
@oe-bors
Copy link

oe-bors bot commented Nov 8, 2018

try

Build succeeded

@anitagov
Copy link
Contributor Author

anitagov commented Nov 8, 2018

bors r+

oe-bors bot pushed a commit that referenced this pull request Nov 8, 2018
1023: Test to verify TCS exhaustion to address missing thread binding coverage  r=anitagov a=anitagov

New thread binding test coverage to verify TCS exhaustion i.e. enter on N threads when there are M TCSes where N > M 
oe_call should return OE_OUT_OF_THREADS when M enclaves are in use.
Trick is to keep the M enclaves busy until we get TCS exhaustion and run out of all the threads.
This was mentioned in Issue #24 

Co-authored-by: Anita Govindarajan <v-angovi@microsoft.com>
@openenclave openenclave deleted a comment from oe-bors bot Nov 8, 2018
@openenclave openenclave deleted a comment from oe-bors bot Nov 8, 2018
@openenclave openenclave deleted a comment from oe-bors bot Nov 8, 2018
@openenclave openenclave deleted a comment from oe-bors bot Nov 8, 2018
@openenclave openenclave deleted a comment from oe-bors bot Nov 8, 2018
@oe-bors
Copy link

oe-bors bot commented Nov 8, 2018

Build succeeded

@oe-bors oe-bors bot merged commit 3937e80 into master Nov 8, 2018
Public preview automation moved this from Backlog to Done Nov 8, 2018
@oe-bors oe-bors bot deleted the anitagov.thread.coverage branch November 8, 2018 23:40
@openenclave openenclave deleted a comment from johnkord Nov 8, 2018
@openenclave openenclave deleted a comment from oe-bors bot Nov 8, 2018
@openenclave openenclave deleted a comment from johnkord Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issue has to do with testing or quality management
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants