New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need for maintained docker images #1341
Remove the need for maintained docker images #1341
Conversation
I think this is way easier than manually maintaining a private Docker registry with our image 👍 bors try |
tryBuild succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnkord I am totally down for and love this change. We just need to check ordering and document how to purge those caches (or consider if that's even necessary, since I think that Docker should notice a change to a Dockerfile and then create new layers for updated packages).
Dockerfile won't change since it is just including an ansible playbook. |
That addresses my concern! Oh I am excited for this 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, let's do it
John and I figured out ordering, as this PR conflicts with a few other open ones. We're going to merge this first as it should reduce the work in later PRs by eliminating the need to manually update the Docker image. bors r+ Thanks! |
Build failed |
bors r+ |
Build failed |
bors r+ |
Build succeeded |
Changed Jenkinsfile to build oetools image and use docker cached layers instead of pulling pre-built image from private registry