Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for maintained docker images #1341

Merged

Conversation

oprinmarius
Copy link
Contributor

Changed Jenkinsfile to build oetools image and use docker cached layers instead of pulling pre-built image from private registry

@andyleejordan
Copy link
Member

I think this is way easier than manually maintaining a private Docker registry with our image 👍

bors try

oe-bors bot pushed a commit that referenced this pull request Jan 16, 2019
@oe-bors
Copy link

oe-bors bot commented Jan 16, 2019

try

Build succeeded

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnkord I am totally down for and love this change. We just need to check ordering and document how to purge those caches (or consider if that's even necessary, since I think that Docker should notice a change to a Dockerfile and then create new layers for updated packages).

@oprinmarius
Copy link
Contributor Author

@johnkord I am totally down for and love this change. We just need to check ordering and document how to purge those caches (or consider if that's even necessary, since I think that Docker should notice a change to a Dockerfile and then create new layers for updated packages).

Dockerfile won't change since it is just including an ansible playbook.
It is adding the scripts/ansible folder before starting the build though. So any changes to the scripts/ansible/ folder would trigger new builds since the first layer is changed.

@andyleejordan
Copy link
Member

That addresses my concern! Oh I am excited for this 😂

Copy link
Contributor

@johnkord johnkord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, let's do it

@andyleejordan
Copy link
Member

John and I figured out ordering, as this PR conflicts with a few other open ones. We're going to merge this first as it should reduce the work in later PRs by eliminating the need to manually update the Docker image.

bors r+

Thanks!

oe-bors bot pushed a commit that referenced this pull request Jan 18, 2019
1341: Remove the need for maintained docker images r=andschwa a=oprinmarius

Changed Jenkinsfile to build oetools image and use docker cached layers instead of pulling pre-built image from private registry

Co-authored-by: Marius Oprin <moprin@cloudbasesolutions.com>
@oe-bors
Copy link

oe-bors bot commented Jan 19, 2019

Build failed

@andyleejordan
Copy link
Member

bors r+

oe-bors bot pushed a commit that referenced this pull request Jan 19, 2019
1341: Remove the need for maintained docker images r=andschwa a=oprinmarius

Changed Jenkinsfile to build oetools image and use docker cached layers instead of pulling pre-built image from private registry

Co-authored-by: Marius Oprin <moprin@cloudbasesolutions.com>
@oe-bors
Copy link

oe-bors bot commented Jan 19, 2019

Build failed

@andyleejordan
Copy link
Member

bors r+

oe-bors bot pushed a commit that referenced this pull request Jan 19, 2019
1341: Remove the need for maintained docker images r=andschwa a=oprinmarius

Changed Jenkinsfile to build oetools image and use docker cached layers instead of pulling pre-built image from private registry

Co-authored-by: Marius Oprin <moprin@cloudbasesolutions.com>
@oe-bors
Copy link

oe-bors bot commented Jan 19, 2019

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants