Expose sgx report body fields by oe claims #3723
Conversation
qiucwang
requested review from
CodeMonkeyLeet,
gupta-ak,
mikbras and
radhikaj
as code owners
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
|
bors retry |
3723: Expose sgx report body fields by oe claims r=yentsanglee a=qiucwang Fixes #3689 Added two more fields in `sgx_report_body` struct that consistent with intel [SGX report structure](https://github.com/intel/SGXDataCenterAttestationPrimitives/blob/master/QuoteGeneration/common/inc/internal/linux/arch.h#L55-L77) ``` uint8_t configid[64]; uint16_t configsvn; ``` Added oe_claim entries to expose `sgx_report_body` fields. Flag fields as `misc_select` and `attributes` are converted to multiple booleans. Signed-off-by: Qiucheng Wang <qiucwang@microsoft.com> Co-authored-by: Qiucheng Wang <qiucwang@microsoft.com>
|
Build failed: |
common/sgx/verifier.c
Outdated
| @@ -302,6 +312,91 @@ static oe_result_t _fill_with_known_claims( | |||
| format_id, | |||
| sizeof(*format_id))); | |||
|
|
|||
| // SGX Report CPU SVN | |||
There was a problem hiding this comment.
CPUSVN in SGX QUOTE/REPORT is a "hint" only. Security analysis should not be made based on the CPUSVN value reported by the SGX enclave SW, including the SGX PCE/QE. The SGX CPU's security property is endorsed by the PCK Cert Chain. The leaf cert of the PCK Cert Chain includes SVNs of CPU firmware/microcode modules that are inside SGX TCB. Successful QUOTE verification, using the PCK Cert Chain, indicates the underlining SGX CPU's security property is equal to or higher than the SVNs in the PCK Cert Chain leaf Cert. The SVNs in the PCK Cert Chain leaf Cert might be associated with a SGX TCB that's out-of-date, ie, with known vulnerability. In that case, it's possible that the enclave SW that produced the SGX QUOTE has been compromised and might have spoofed the CPUSVN value in the SGX QUOTE. Only if the leaf Cert indicates the SGX CPU is free of any known security vulnerability, should the CPUSVN value in SGX QUOTE be trusted.
CPUSVN value in SGX QUOTE/REPORT is an opaque value. Two different value of CPUSVN can not be numerically compared for TCB level comparison purpose.
Therefore, exposing the CPUSVN value in SGX QUOTE as a claim almost has no value. It should not be included in the outputted claims.
There was a problem hiding this comment.
Hid CPUSVN from QUOTE.
|
Looks good to me. |
|
bors r+ |
|
👎 Rejected by code reviews |
|
bors retry |
|
👎 Rejected by code reviews |
|
bors retry |
3723: Expose sgx report body fields by oe claims r=yentsanglee a=qiucwang Fixes #3689 Added two more fields in `sgx_report_body` struct that consistent with intel [SGX report structure](https://github.com/intel/SGXDataCenterAttestationPrimitives/blob/master/QuoteGeneration/common/inc/internal/linux/arch.h#L55-L77) ``` uint8_t configid[64]; uint16_t configsvn; ``` Added oe_claim entries to expose `sgx_report_body` fields. Flag fields as `misc_select` and `attributes` are converted to multiple booleans. Signed-off-by: Qiucheng Wang <qiucwang@microsoft.com> Co-authored-by: Qiucheng Wang <qiucwang@microsoft.com>
|
Build failed: |
|
bors try |
tryBuild failed: |
Signed-off-by: Qiucheng Wang <qiucwang@microsoft.com>
|
bors try |
tryBuild failed: |
|
bors retry |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
Fixes #3689
Added two more fields in
sgx_report_bodystruct that consistent with intel SGX report structureAdded oe_claim entries to expose
sgx_report_bodyfields. Flag fields asmisc_selectandattributesare converted to multiple booleans.Signed-off-by: Qiucheng Wang qiucwang@microsoft.com