Use target_link_options for linker commands and update the dependency #3822
+2,001
−947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graph Signed-off-by: Ming-Wei Shih <mishih@microsoft.com>
mingweishih
requested review from
andyleejordan,
BRMcLaren and
a team
as code owners
|
bors try |
tryBuild failed: |
mingweishih
added
the
blocked
|
This requires cmake 3.13. However, VS 2017 we use on windows only supports 3.12. |
|
@mingweishih - can you resolve conflicts? |
radhikaj
requested review from
radhikaj and
anakrish
and removed request for
BRMcLaren
|
@mingweishih Please resolve conflicts and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
target_link_optionsto specify linker options, avoiding the confusing cmake when producing dependency graphs. Also, update the dependency graphs.Fixes #3225
Signed-off-by: Ming-Wei Shih mishih@microsoft.com