Added tests for creating enclaves via OCALLs. #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeMonkeyLeet
approved these changes
Jul 11, 2018
| @@ -0,0 +1 @@ | |||
| run enc/ocall_create_enc.signed.so | |||
There was a problem hiding this comment.
We can drop this file
| { | ||
| oe_host_printf("==== Host: TestOCallEnclave\n"); | ||
|
|
||
| TestEnclaveArgs* args = (TestEnclaveArgs*)args_; |
There was a problem hiding this comment.
For future reference: The recommendation to devs is to make local copies of input args to prevent time-of-check to time-of-use (TOCTOU) issues. We haven't applied this consistently to tests in the codebase, but we should probably not introduce more instances where we fail to do this (see ocall-ecall tests for an example)
CodeMonkeyLeet
added
the
testing
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.