Bugfix.issue#478 #541
Bugfix.issue#478 #541
Conversation
include/openenclave/bits/report.h
Outdated
| @@ -68,7 +68,7 @@ typedef struct _oe_identity | |||
|
|
|||
| /** The author ID for the enclave. | |||
include/openenclave/bits/report.h
Outdated
| @@ -68,7 +68,7 @@ typedef struct _oe_identity | |||
|
|
|||
| /** The author ID for the enclave. | |||
| * For SGX enclaves, this is the MRSIGNER value */ | |||
| uint8_t author_id[OE_AUTHOR_ID_SIZE]; | |||
| uint8_t signerID[OE_SIGNER_ID_SIZE]; | |||
There was a problem hiding this comment.
@anitagov Is there any impact to existing documentation due to this field rename? I think you worked on documenting some of the attestation APIs.
There was a problem hiding this comment.
This definitely affects the html files but .md file does not show the data structures in report.h. @vishnumohan1991 - Good idea to run make refman-source and verify that there are no modified .md files.
There was a problem hiding this comment.
Instead of updating the .md files, I would recommend simply removing the .md files as part of task #545 in your next PR.
common/report.c
Outdated
| @@ -54,10 +54,10 @@ static void _oe_parse_sgx_report_body( | |||
| sizeof(reportBody->mrenclave)); | |||
|
|
|||
| OE_STATIC_ASSERT( | |||
| sizeof(parsedReport->identity.author_id) >= | |||
| sizeof(parsedReport->identity.signerID) >= | |||
There was a problem hiding this comment.
The name of the field should be "signer_id". We can change it now or let the camel2snake tool catch it before release.
There was a problem hiding this comment.
Please update it to identity.signer_id before merging.
.cspellignore
Outdated
| @@ -309,6 +309,7 @@ Spectre | |||
| ld | |||
| pubKey | |||
| AuthorID | |||
There was a problem hiding this comment.
You should be able to remove AuthorID since we don't use that term in OE anymore … similarly, see if you can remove SignerID once you switch it to match snake casing (i.e. signer_id)
CodeMonkeyLeet
added
the
functionality
vishnumohan1991
force-pushed
the
bugfix.issue#478
branch
from
78ba7f6
to
64009bf
Compare
|
@vishnumohan1991 Please investigate and resolve the build failure. You might need to merge from master again and see if that resolves the issue for you. |
|
The build conflicts are resolved due to merging but Jenkins test is not running against the latest pushed changes. I have verified my commits against coffelake and kabylake machines in debug,release,relwithdebinfo and no issues found yet While checking the build it shows the automated build in Jenkins environment is queued and not processing at all. Can you comment on this behavior? |
|
@vishnumohan1991 John has since restored the CI pipeline so I've merged your changes. |
Renamed authorID field in oe_identity structure to signerID