Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for host memory mangement in enclave. #655

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Conversation

gupta-ak
Copy link
Contributor

@gupta-ak gupta-ak commented Sep 7, 2018

No description provided.

Copy link
Contributor

@CodeMonkeyLeet CodeMonkeyLeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some comment cleanup

OE_TEST(memcmp(args.outStr, "he", 3) == 0);
OE_TEST(oe_call_enclave(enclave, "HostFree", args.outStr) == OE_OK);

/* String length is greater than size. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment for this and the previous case seem to be inverted

@gupta-ak
Copy link
Contributor Author

bors r+

oe-bors bot pushed a commit that referenced this pull request Sep 18, 2018
655: Added tests for host memory mangement in enclave. r=gupta-ak a=gupta-ak



Co-authored-by: Akash Gupta <akagup@microsoft.com>
@oe-bors
Copy link

oe-bors bot commented Sep 18, 2018

Build succeeded

@oe-bors oe-bors bot merged commit bad1b39 into master Sep 18, 2018
@oe-bors oe-bors bot deleted the akagup/hostmemory branch September 18, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issue has to do with testing or quality management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants