Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled Windows CI builds. #993

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Enabled Windows CI builds. #993

merged 1 commit into from
Oct 30, 2018

Conversation

johnkord
Copy link
Contributor

No description provided.

@johnkord johnkord added testing Issue has to do with testing or quality management windows Issue has to do with supporting Open Enclave on Windows labels Oct 29, 2018
@johnkord johnkord added this to the 2018.10 milestone Oct 29, 2018
@johnkord johnkord self-assigned this Oct 29, 2018
@johnkord
Copy link
Contributor Author

This enables a basic set of 5 tests on Windows. More work is to be done to enable more tests with the -DADD_WINDOWS_ENCLAVE_TESTS=1 flag.

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
15a22a5
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build failed

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
73df77a
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build failed

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
72beaa9
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build failed

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
2d5ee62
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build failed

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
6f4ed89
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build failed

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
9ac4214
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build failed

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
0b5b4ef
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build failed

@johnkord
Copy link
Contributor Author

bors try

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Try #993:
509bfca
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

try

Build succeeded

gupta-ak
gupta-ak approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@gupta-ak gupta-ak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

CodeMonkeyLeet
CodeMonkeyLeet reviewed Oct 30, 2018
View reviewed changes
.jenkins/Jenkinsfile

}
steps {
bat '''mkdir build && cd build && cmake -G "Visual Studio 15 2017 Win64" .. && pushd . && "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\Tools\\LaunchDevCmd.bat" && popd && cmake --build . --config Debug && ctest -C Debug'''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonblocking: consider making this a separate script file like test-build-config and simplifying where appropriate (e.g. why not just do everything in the dev shell instead of pushd & popd across the shell transition?)

@johnkord
Copy link
Contributor Author

bors r+

oe-bors bot pushed a commit that referenced this pull request Oct 30, 2018
@oeciteam
Merge #993
87ed7e1 
993: Enabled Windows CI builds. r=johnkord a=johnkord



Co-authored-by: John Kordich <johnkord@microsoft.com>
@oe-bors
Copy link

oe-bors bot commented Oct 30, 2018

Build succeeded

@oe-bors oe-bors bot merged commit e93f8bd into master Oct 30, 2018
@oe-bors oe-bors bot deleted the johnkord-CI_add_windows branch October 30, 2018 20:54
@CodeMonkeyLeet CodeMonkeyLeet added this to In progress in v0.5x via automation Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet added the ci/cd Issue is related to the code integration/deployment pipeline label Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet moved this from In progress to Done in v0.5x Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet mentioned this pull request Nov 7, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeMonkeyLeet CodeMonkeyLeet CodeMonkeyLeet left review comments

@gupta-ak gupta-ak gupta-ak approved these changes

@yakman2020 yakman2020 Awaiting requested review from yakman2020

@anakrish anakrish Awaiting requested review from anakrish

Assignees

@johnkord johnkord

Labels
ci/cd Issue is related to the code integration/deployment pipeline testing Issue has to do with testing or quality management windows Issue has to do with supporting Open Enclave on Windows
Projects
No open projects
v0.5x
  
Done
Milestone
2018.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnkord @gupta-ak @CodeMonkeyLeet