Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units of type suffix should have a suffix #1019

Closed
huss opened this issue Sep 25, 2023 · 1 comment · Fixed by #1040
Closed

Units of type suffix should have a suffix #1019

huss opened this issue Sep 25, 2023 · 1 comment · Fixed by #1040
Assignees

Comments

@huss
Copy link
Member

huss commented Sep 25, 2023

Describe the bug

Currently a unit can be of type suffix but not have a suffix included and the inverse is also possible for both creating and editing a unit. It does not make sense to have such a combination and an admin should be forced to include both or neither. If a suffix is added but the unit is not of type suffix then the admin should be told the type will be changed to suffix. If the unit is of type suffix but there is no suffix unit then the suffix input should become red and an entry required before saving.

Screenshots

Examples for create a unit are shown but edit behaves similarly.

Screenshot 2023-09-25 073325

Screenshot 2023-09-25 073307

Additional context

Currently the admin help warns about doing this so hopefully it will not happen but this fix would mean the documentation can be updated to say it cannot happen.

@Jake-Bodin
Copy link
Contributor

I want to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants