Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only get version once #1048

Closed
huss opened this issue Oct 19, 2023 · 1 comment · Fixed by #1057
Closed

only get version once #1048

huss opened this issue Oct 19, 2023 · 1 comment · Fixed by #1057
Assignees
Labels
p-low-priority reserved Expected to be assigned to developer by project so others should not work on without prior approval. t-enhancement This issues tracks a potential improvement to the software

Comments

@huss
Copy link
Member

huss commented Oct 19, 2023

Is your feature request related to a problem? Please describe.

OED displays the version at the bottom of each page. Each time you change pages (to/from graphic page or any other page) it does an api call to get the version. Since the version cannot change except after an upgrade, the version will remain the same so this api call is unneeded.

Describe the solution you'd like

If there is a version in Redux state then the api call should not be made. The code in src/client/app/actions/version.ts already has a shouldFetchVersion() function so it can be augmented to check for the Redux state.

Describe alternatives you've considered

OED works fine but this is an inefficiency and not in line with the new way other state is only fetched once.

Additional context

None

@huss huss added t-enhancement This issues tracks a potential improvement to the software p-low-priority reserved Expected to be assigned to developer by project so others should not work on without prior approval. labels Oct 19, 2023
@Jake-Bodin
Copy link
Contributor

I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-low-priority reserved Expected to be assigned to developer by project so others should not work on without prior approval. t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants