Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS + Not using emoncms.org + /emoncms = Doesn't work #34

Closed
sindudas opened this issue Jan 24, 2018 · 6 comments
Closed

HTTPS + Not using emoncms.org + /emoncms = Doesn't work #34

sindudas opened this issue Jan 24, 2018 · 6 comments
Labels

Comments

@sindudas
Copy link

If I use https://example.com/emoncms as my EmonCMS server, I can't use HTTPS.

It's because when trying to connect to Server, uses "example.com/emomcms" has "host", and
client.connect(host, httpsPort) fails.
If I put "/emoncms" at the beginning of "e_url", and leave "host" as "example.com" it works!

Maybe an input box to put the server url, will help.

@glynhudson glynhudson added the bug label Jan 24, 2018
@glynhudson
Copy link
Member

I can confirm we have been able to replicate the issue. Thanks a lot for flagging this up. I'll take a look

@mabi
Copy link
Contributor

mabi commented Mar 15, 2018

I am addressing this issue in my branch dev-issue34 still work in progress.

@mabi
Copy link
Contributor

mabi commented Mar 15, 2018

@sindudas @glynhudson can you please build and test my branch? I don't have the hardware at hand.

@sindudas
Copy link
Author

Flash erase , and then upload firmware and spiffs. Configured and published data through HTTPS

Good job! Thanks

@mabi
Copy link
Contributor

mabi commented Mar 16, 2018

@sindudas thank you for the test! I will update the docs with new screenshot and create a pull request, then we can close the issue

@glynhudson
Copy link
Member

glynhudson commented Mar 28, 2018

Nice work, please could you submit a PR for this. Happy to merge. Thanks a lot

Sorry, just seen your PR..Doh! I'll test and merge. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants