Properly rewrite VEDirect interfacer for Python3. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main problem was trying to decode the checksum byte (0-255) as utf-8 (0-127 plus continuation bytes), so we have to store everything as bytes until we are ready to decode it. I also took the opportunity to rewrite a few things in a simpler / more pythonic style. This might raise different exceptions when things go wrong, but it is shorter and it should be simpler to understand. I tried to add some helpful comments!
Exit the read_serial loop if the data are bad. This will return to the interfacer loop and try again in "pool_interval" time, instead of waiting forever for valid data.
|
Hello @bwduncan I've been able to fix the conflicts here, should I merge this? |
|
Yes please, the code was quite broken so even if this doesn't work it's a worthwhile incremental improvement and I would much rather people are testing this than the previous code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem was trying to decode the checksum byte (0-255) as utf-8
(0-127 plus continuation bytes), so we have to store everything as bytes
until we are ready to decode it.
I also took the opportunity to rewrite a few things in a simpler / more
pythonic style. This might raise different exceptions when things go
wrong, but it is shorter and it should be simpler to understand. I
tried to add some helpful comments!
It's now 1am and I don't have hardware to test this. I would appreciate anyone looking over this with a beady eye!