This repository has been archived by the owner on May 24, 2022. It is now read-only.
chore(deps): Update package to fix vulnerabilities #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelchalon
approved these changes
Oct 29, 2019
Tbaut
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
yarn electron --ipc-path... with external node, yarn electron --chain kovan and AppImage after yarn package :
✔️ ETH transfer
✔️ add Signer account
✔️ Signer ETH transfer
yarn package was throwing a bit while doing node-gyp rebuild 🤷♂️
full gist: https://gist.github.com/Tbaut/366d51dad17a5395b0fa88408553a9b0
|
Yes, I have the same. Let's try on CI and test the binary, if everything's good then we can just ignore this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would appreciate a:
yarn startyarn electronyarn packagebefore merging, to double check that everything works