Store tokens with repeatable id (#7435)

openethereum · Jan 3, 2018 · 7c1cbd3 · 7c1cbd3
1 parent 51319eb
commit 7c1cbd3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/js-old/src/redux/providers/tokensActions.js b/js-old/src/redux/providers/tokensActions.js
@@ -23,7 +23,7 @@ import { fetchTokenIds, fetchTokensBasics, fetchTokensInfo, fetchTokensImages }
 
 import { setAddressImage } from './imagesActions';
 
-const TOKENS_CACHE_LS_KEY_PREFIX = '_parity::tokens::';
+const TOKENS_CACHE_LS_KEY_PREFIX = '_parity::tokenreg::';
 const log = getLogger(LOG_KEYS.Balances);
 
 function _setTokens (tokens) {

diff --git a/js-old/src/util/tokens/index.js b/js-old/src/util/tokens/index.js
@@ -59,30 +59,32 @@ export function fetchTokensBasics (api, tokenReg, start = 0, limit = 100) {
     })
     .then((tokenAddresses) => {
       return tokenAddresses.map((tokenAddress, index) => {
-        if (/^0x0*$/.test(tokenAddress)) {
-          return null;
-        }
-
         const tokenIndex = start + index;
 
         return {
-          address: tokenAddress,
-          id: getTokenId(tokenAddress, tokenIndex),
+          address: /^0x0*$/.test(tokenAddress)
+            ? ''
+            : tokenAddress,
+          id: getTokenId(tokenIndex),
           index: tokenIndex,
-
           fetched: false
         };
       });
     })
-    .then((tokens) => tokens.filter((token) => token))
     .then((tokens) => {
       const randomAddress = sha3(`${Date.now()}`).substr(0, 42);
 
       return fetchTokensBalances(api, tokens, [randomAddress])
         .then((_balances) => {
           const balances = _balances[randomAddress];
 
-          return tokens.filter(({ id }) => balances[id].eq(0));
+          return tokens.map((token) => {
+            if (balances[token.id] && balances[token.id].gt(0)) {
+              token.address = '';
+            }
+
+            return token;
+          });
         });
     });
 }
@@ -113,7 +115,7 @@ export function fetchTokensInfo (api, tokenReg, tokenIndexes) {
 
         const token = {
           address,
-          id: getTokenId(address, tokenIndex),
+          id: getTokenId(tokenIndex),
           index: tokenIndex,
 
           format: format.toString(),