Handle invalid ABI retrieved from address_book gracefully (#4606) (#4610

) * Handle invalid ABI gracefully * Also include failed abi in log
openethereum · Feb 20, 2017 · 7df7024 · 7df7024
1 parent b5219bc
commit 7df7024
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/js/src/ui/MethodDecoding/methodDecodingStore.js b/js/src/ui/MethodDecoding/methodDecodingStore.js
@@ -55,9 +55,19 @@ export default class MethodDecodingStore {
   }
 
   loadFromAbi (_abi, contractAddress) {
-    const abi = new Abi(_abi);
+    let abi;
 
-    if (contractAddress && abi) {
+    try {
+      abi = new Abi(_abi);
+    } catch (error) {
+      console.warn('loadFromAbi', error, _abi);
+    }
+
+    if (!abi) {
+      return;
+    }
+
+    if (contractAddress) {
       this._contractsAbi[contractAddress] = abi;
     }