Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add very basic smoketests for all UI components #2289

Closed
jacogr opened this issue Sep 23, 2016 · 1 comment
Closed

Add very basic smoketests for all UI components #2289

jacogr opened this issue Sep 23, 2016 · 1 comment
Assignees
@jacogr
Projects
User Interface

Comments

@jacogr
Copy link
Contributor

jacogr commented Sep 23, 2016 •
edited
Loading

Make start - a number of issues could be catched early with minimal work & overhead

From @tomusdrw -

What do you think about doing at least a single smoke test for each component? Without any assertions, e.g

https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#testing-components

just it renders without crashing
jacogr added a commit that referenced this issue Dec 8, 2016
@jacogr
ui/Container tests as per #2289
b3f7c00
jacogr added a commit that referenced this issue Dec 8, 2016
@jacogr
Expanded basic tests for #2289
a5b5277
@jacogr jacogr mentioned this issue Dec 8, 2016
Merged
@jacogr
Copy link
Contributor Author

jacogr commented Feb 10, 2017

Initial effort done, adding as files are added.

@jacogr jacogr closed this as completed Feb 10, 2017
@jacogr jacogr moved this from In Progress to Done in User Interface Feb 12, 2017
@jacogr jacogr self-assigned this Feb 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jacogr jacogr

Labels
None yet
Projects
No open projects
User Interface
Done (1.6.0)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavofyork @jacogr