Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Method Decoding for contract deployment should show constructor parameters #3715

Closed
jacogr opened this issue Dec 5, 2016 · 1 comment
Closed

Method Decoding for contract deployment should show constructor parameters #3715

jacogr opened this issue Dec 5, 2016 · 1 comment
Assignees
@ngotchac
Labels
F8-enhancement 🎊 An additional feature request.
Projects
User Interface

Comments

@jacogr
Copy link
Contributor

jacogr commented Dec 5, 2016

Assumes that the ABI is available is to the decoder, either via lookup or via pass-through, e.g. from internal deployments where the ABI is known up-front.
@jacogr jacogr added F8-enhancement 🎊 An additional feature request. M7-ui labels Dec 5, 2016
@ngotchac ngotchac self-assigned this Jan 3, 2017
@ngotchac
Copy link
Contributor

ngotchac commented Jan 3, 2017

The input of a Contract Deployment only contains the bytecode concatenated with the constructor params. Thus, to decode a Contract Deployment transaction, the UI must know the bytecode (which can always be fetched anyway) and the ABI. This is fairly easy for an internal deployment, however it becomes tricky when it is not a contract added to the UI: there are no traces of the Contract constructor signature, AFAIK

ngotchac added a commit that referenced this issue Jan 3, 2017
@ngotchac
Add decoding of Inner Contract Deployment params #3715
c0da6cb
@ngotchac ngotchac mentioned this issue Jan 3, 2017
Merged
jacogr pushed a commit that referenced this issue Jan 5, 2017
@ngotchac @jacogr
Show contract parameters in MethodDecoding (#4024)
d16ab5e 
* Add decoding of Inner Contract Deployment params #3715

* Fixed TypedInput when formatted value

* Fix TypedInput

* PR Grumble

* Add test to `Param.toParams`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ngotchac ngotchac

Labels
F8-enhancement 🎊 An additional feature request.
Projects
No open projects
User Interface
Done (1.5.0)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacogr @ngotchac