Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Replace usages of ::std::env::temp_dir with tempdir crate in tests #6147

Closed
debris opened this issue Jul 25, 2017 · 2 comments · Fixed by #8103
Closed

Replace usages of ::std::env::temp_dir with tempdir crate in tests #6147

debris opened this issue Jul 25, 2017 · 2 comments · Fixed by #8103
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone
1.11 Prosperity

Comments

@debris
Copy link
Collaborator

debris commented Jul 25, 2017

#6140 (comment)
@debris debris added M4-core ⛓ Core client code / Rust. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jul 25, 2017
nicolasochem pushed a commit to nicolasochem/parity that referenced this issue Aug 2, 2017
WIP - Replace usages of ::std::env::temp_dir with tempdir crate in te…
7da28b6 
…sts openethereum#6147
nicolasochem pushed a commit to nicolasochem/parity that referenced this issue Aug 2, 2017
WIP - Replace usages of ::std::env::temp_dir with tempdir crate in te…
89ea78f 
…sts openethereum#6147
nicolasochem pushed a commit to nicolasochem/parity that referenced this issue Aug 2, 2017
Replace usages of ::std::env::temp_dir with tempdir crate in tests
30401d6 
Fix openethereum#6147
@nicolasochem nicolasochem mentioned this issue Aug 2, 2017
Closed
@5chdn 5chdn added F6-refactor 📚 Code needs refactoring. and removed A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Aug 7, 2017
@5chdn 5chdn added the P7-nicetohave 🐕 Issue is worth doing eventually. label Sep 4, 2017
@5chdn 5chdn added this to the 1.10 & ... milestone Oct 5, 2017
@debris debris mentioned this issue Oct 17, 2017
Merged
@GeorgiosAthanasiadis
Copy link

WIP - Replace usages of ::std::env::temp_dir with tempdir crate in tests #6146

@kirushik
Copy link
Collaborator

@GeorgiosAthanasiadis Hi!
What's your status with this issue? Do you need any help in finalizing your work?

Please keep in mind that only PRs submitted in October (which ends tomorrow) qualify for Hacktoberfest.

@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@niklasad1 niklasad1 mentioned this issue Mar 13, 2018
Merged
@5chdn 5chdn modified the milestones: 1.12, 1.11 Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging a pull request may close this issue.

Replace std::env::temp_dir with tempdir in tests openethereum/parity-ethereum
4 participants
@kirushik @debris @5chdn @GeorgiosAthanasiadis