Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Last part of util refactor #6693

Closed
4 tasks done
debris opened this issue Oct 10, 2017 · 3 comments · Fixed by #7460
Closed
4 tasks done

Last part of util refactor #6693

debris opened this issue Oct 10, 2017 · 3 comments · Fixed by #7460
Labels
F6-refactor 📚 Code needs refactoring. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Milestone
1.10

Comments

@debris
Copy link
Collaborator

debris commented Oct 10, 2017 •
edited

last part of #6418

  • kvdb should be separated into 2 separate crates: kvdb and kvrocksdb which implements key-value interface for rocksdb
  • journal crate should be separated from util. overlaydb and util_error crate should be merged into it. also UtilError should be just renamed to Error.
  • cache should be separated from util
  • util should be dissolved
@debris debris added F6-refactor 📚 Code needs refactoring. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Oct 10, 2017
@5chdn 5chdn added this to the 1.8 milestone Oct 10, 2017
@5chdn 5chdn mentioned this issue Oct 10, 2017
Closed
67 tasks
@debris
Copy link
Collaborator Author

debris commented Oct 11, 2017

I will take

  • kvdb should be separated into 2 separate crates: kvdb and kvrocksdb which implements key-value interface for rocksdb

@0x7CFE
Copy link
Contributor

0x7CFE commented Oct 12, 2017

I will take cache and then probably journal stuff.

debris added a commit that referenced this issue Oct 12, 2017
@debris
separated kvdb into 3 crates: kvdb, kvdb-memorydb && kvdb-rocksdb, #6693
eb526b7
@debris debris mentioned this issue Oct 12, 2017
Merged
@5chdn 5chdn modified the milestones: 1.8, 1.9 Oct 12, 2017
0x7CFE added a commit that referenced this issue Oct 15, 2017
@0x7CFE
Extracts MemoryLruCache to a separate crate (#6693)
aab9ca5
0x7CFE added a commit that referenced this issue Oct 15, 2017
@0x7CFE
Refactors references to MemoryLruCache in ethcore (#6693)
4014c64
0x7CFE added a commit that referenced this issue Oct 15, 2017
@0x7CFE
Extracts MemoryLruCache to a separate crate (#6693)
ef5ef99
0x7CFE added a commit that referenced this issue Oct 15, 2017
@0x7CFE
Refactors references to MemoryLruCache in ethcore (#6693)
786ea98
@0x7CFE 0x7CFE mentioned this issue Oct 15, 2017
Merged
0x7CFE added a commit that referenced this issue Oct 15, 2017
@0x7CFE
Extracts MemoryLruCache to a separate crate (#6693)
51b61cc
0x7CFE added a commit that referenced this issue Oct 15, 2017
@0x7CFE
Refactors references to MemoryLruCache in ethcore (#6693)
4df541e
0x7CFE added a commit that referenced this issue Oct 15, 2017
@0x7CFE
Removes redundant dependencies (#6693)
e7690ab
@0x7CFE
Copy link
Contributor

0x7CFE commented Oct 16, 2017

Now working on journal.

0x7CFE added a commit that referenced this issue Oct 16, 2017
@0x7CFE
Moves journaldb sources to a separate crate (#6693)
dd3187c
0x7CFE added a commit that referenced this issue Oct 17, 2017
@0x7CFE
Refactors ethcore to use journaldb crate (#6693)
1dee197
0x7CFE added a commit that referenced this issue Oct 17, 2017
@0x7CFE
Refactors parity/parity to use journaldb crate (#6693)
724f823
0x7CFE added a commit that referenced this issue Oct 17, 2017
@0x7CFE
Moves journaldb sources to a separate crate (#6693)
e2b96e1
0x7CFE added a commit that referenced this issue Oct 17, 2017
@0x7CFE
Refactors ethcore to use journaldb crate (#6693)
c0fc839
0x7CFE added a commit that referenced this issue Oct 17, 2017
@0x7CFE
Refactors parity/parity to use journaldb crate (#6693)
f9e588d
@0x7CFE 0x7CFE mentioned this issue Oct 17, 2017
Merged
@5chdn 5chdn mentioned this issue Dec 15, 2017
Closed
64 tasks
@debris debris mentioned this issue Jan 4, 2018
Merged
@debris debris modified the milestones: 1.9, 1.10 Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F6-refactor 📚 Code needs refactoring. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

dissolve util openethereum/parity-ethereum
3 participants
@debris @0x7CFE @5chdn