Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

rpc: trace_replayBlockTransactions respond with error to set pruning to archive even if it is set #7547

Closed
Serozd opened this issue Jan 12, 2018 · 4 comments
Assignees
Labels
F2-bug 🐞 The client fails to follow expected behavior. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone

Comments

@Serozd
Copy link

Serozd commented Jan 12, 2018

parity version: Parity/v1.10.0-unstable-b6e61f403-20180112/x86_64-linux-gnu/rustc1.22.1
installed from source
node is running with those flgs: parity --config dev --tracing on --pruning=archive --rpcapi eth,personal,net,parity,traces

there is issue with replayBlockTransactions:
curl --data '{"method":"trace_replayBlockTransactions","params":["0x0", ["trace", "stateDiff", "vmTrace"]],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST localhost:8545
actual result:
{"jsonrpc":"2.0","error":{"code":-32000,"message":"This request is not supported because your node is running with state pruning. Run with --pruning=archive."},"id":1}
expected result:
response with traces and not an error

node startup stdout:
2018-01-12 18:25:28 Starting Parity/v1.10.0-unstable-b6e61f403-20180112/x86_64-linux-gnu/rustc1.22.1
2018-01-12 18:25:28 Keys path /home//.local/share/io.parity.ethereum/keys/DevelopmentChain
2018-01-12 18:25:28 DB path /home/
/.local/share/io.parity.ethereum/chains/DevelopmentChain/db/125ccdc70e48df86
2018-01-12 18:25:28 Path to dapps /home/*/.local/share/io.parity.ethereum/dapps
2018-01-12 18:25:28 State DB configuration: archive +Trace
2018-01-12 18:25:28 Operating mode: active
2018-01-12 18:25:28 Warning: Warp Sync is disabled because tracing is turned on.
2018-01-12 18:25:28 Configured for DevelopmentChain using InstantSeal engine

@Serozd Serozd changed the title rpc: trace_replayBlockTransactions respond with error to set prunning to archive even if it is set rpc: trace_replayBlockTransactions respond with error to set pruning to archive even if it is set Jan 12, 2018
@Serozd
Copy link
Author

Serozd commented Jan 12, 2018

regarding #7366

@5chdn
Copy link
Contributor

5chdn commented Jan 16, 2018

cc @tzapu

@5chdn 5chdn added F2-bug 🐞 The client fails to follow expected behavior. P5-sometimesoon 🌲 Issue is worth doing soon. M6-rpcapi 📣 RPC API. labels Jan 16, 2018
@5chdn 5chdn added this to the 1.10 milestone Jan 16, 2018
@tzapu
Copy link
Contributor

tzapu commented Jan 16, 2018

hello
my understanding was that this was happening for all rpc requests currently
as mentioned here
#7366 (review)

@Serozd
Copy link
Author

Serozd commented Jan 16, 2018

@tzapu I was not running a public node so there were no syncing state, i guess it should be handled appropriately for dev mode too.

@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@folsen folsen added this to Directly Pickable in Core May 21, 2018
@dvdplm dvdplm moved this from Straightforward Picks to Being Actively Worked On in Core Jun 13, 2018
@dvdplm dvdplm self-assigned this Jun 13, 2018
dvdplm added a commit that referenced this issue Jun 13, 2018
Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762
@dvdplm dvdplm assigned dvdplm and unassigned dvdplm Jun 13, 2018
andresilva pushed a commit that referenced this issue Jun 14, 2018
Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762
tavakyan referenced this issue in C4Coin/c4coin-parity Jun 18, 2018
Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762
andresilva pushed a commit that referenced this issue Jun 18, 2018
Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762
ascjones pushed a commit that referenced this issue Jun 18, 2018
Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762
@ordian ordian moved this from Being Actively Worked On to Easy Picks (Good for external contribution) in Core Jun 18, 2018
@ordian ordian moved this from Easy Picks (Good for external contribution) to Being Actively Worked On in Core Jun 18, 2018
@ordian ordian moved this from Being Actively Worked On to Done in Core Jun 18, 2018
5chdn pushed a commit that referenced this issue Jun 19, 2018
* Fixed AuthorityRound deadlock on shutdown, closes #8088 (#8803)

* CI: Fix docker tags (#8822)

* scripts: enable docker builds for beta and stable

* scripts: docker latest should be beta not master

* scripts: docker latest is master

* Fix concurrent access to signer queue (#8854)

* Fix concurrent access to signer queue

* Put request back to the queue if confirmation failed

* typo: fix docs and rename functions to be more specific

`request_notify` does not need to be public, and it's renamed to `notify_result`.
`notify` is renamed to `notify_message`.

* Change trace info "Transaction" -> "Request"

* Add new ovh bootnodes and fix port for foundation bootnode 3.2 (#8886)

* Add new ovh bootnodes and fix port for foundation bootnode 3.2

* Remove old bootnodes.

* Remove duplicate 1118980bf48b0a3640bdba04e0fe78b1add18e1cd99bf22d53daac1fd9972ad650df52176e7c7d89d1114cfef2bc23a2959aa54998a46afcf7d91809f0855082

* Block 0 is valid in queries (#8891)

Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762

* update jsonrpc libs, fixed ipc leak, closes #8774 (#8876)

Instead of cherrypicking 8b78141, just ran cargo update -p jsonrpc-core

* Add ETC Cooperative-run load balanced parity node (#8892)

* Minor fix in chain supplier and light provider (#8906)

* fix chain supplier increment

* fix light provider block_headers
5chdn pushed a commit that referenced this issue Jun 19, 2018
* `duration_ns: u64 -> duration: Duration` (#8457)

* duration_ns: u64 -> duration: Duration

* format on millis {:.2} -> {}

* Keep all enacted blocks notify in order (#8524)

* Keep all enacted blocks notify in order

* Collect is unnecessary

* Update ChainNotify to use ChainRouteType

* Fix all ethcore fn defs

* Wrap the type within ChainRoute

* Fix private-tx and sync api

* Fix secret_store API

* Fix updater API

* Fix rpc api

* Fix informant api

* Eagerly cache enacted/retracted and remove contain_enacted/retracted

* Fix indent

* tests: should use full expr form for struct constructor

* Use into_enacted_retracted to further avoid copy

* typo: not a function

* rpc/tests: ChainRoute -> ChainRoute::new

* Handle removed logs in filter changes and add geth compatibility field (#8796)

* Add removed geth compatibility field in log

* Fix mocked tests

* Add field block hash in PollFilter

* Store last block hash info for log filters

* Implement canon route

* Use canon logs for fetching reorg logs

Light client removed logs fetching is disabled. It looks expensive.

* Make sure removed flag is set

* Address grumbles

* Fixed AuthorityRound deadlock on shutdown, closes #8088 (#8803)

* CI: Fix docker tags (#8822)

* scripts: enable docker builds for beta and stable

* scripts: docker latest should be beta not master

* scripts: docker latest is master

* ethcore: fix ancient block error msg handling (#8832)

* Disable parallel verification and skip verifiying already imported txs. (#8834)

* Reject transactions that are already in pool without verifying them.

* Avoid verifying already imported transactions.

* Fix concurrent access to signer queue (#8854)

* Fix concurrent access to signer queue

* Put request back to the queue if confirmation failed

* typo: fix docs and rename functions to be more specific

`request_notify` does not need to be public, and it's renamed to `notify_result`.
`notify` is renamed to `notify_message`.

* Change trace info "Transaction" -> "Request"

* Don't allocate in expect_valid_rlp unless necessary (#8867)

* don't allocate via format! in case there's no error

* fix test?

* fixed ipc leak, closes #8774 (#8876)

* Add new ovh bootnodes and fix port for foundation bootnode 3.2 (#8886)

* Add new ovh bootnodes and fix port for foundation bootnode 3.2

* Remove old bootnodes.

* Remove duplicate 1118980bf48b0a3640bdba04e0fe78b1add18e1cd99bf22d53daac1fd9972ad650df52176e7c7d89d1114cfef2bc23a2959aa54998a46afcf7d91809f0855082

* Block 0 is valid in queries (#8891)

Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762

* Add ETC Cooperative-run load balanced parity node (#8892)

* Minor fix in chain supplier and light provider (#8906)

* fix chain supplier increment

* fix light provider block_headers

* Check whether we need resealing in miner and unwrap has_account in account_provider (#8853)

* Remove unused Result wrap in has_account

* Check whether we need to reseal for external transactions

* Fix reference to has_account interface

* typo: missing )

* Refactor duplicates to prepare_and_update_sealing

* Fix build

* Allow disabling local-by-default for transactions with new config entry (#8882)

* Add tx_queue_allow_unknown_local config option

- Previous commit messages:

dispatcher checks if we have the sender account

Add `tx_queue_allow_unknown_local` to MinerOptions

Add `tx_queue_allow_unknown_local` to config

fix order in MinerOptions to match Configuration

add cli flag for tx_queue_allow_unknown_local

Update refs to `tx_queue_allow_unknown_local`

Add tx_queue_allow_unknown_local to config test

revert changes to dispatcher

Move tx_queue_allow_unknown_local to `import_own_transaction`

Fix var name

if statement should return the values

derp de derp derp derp semicolons

Reset dispatch file to how it was before

fix compile issues + change from FLAG to ARG

add test and use `into`

import MinerOptions, clone the secret

Fix tests?

Compiler/linter issues fixed

Fix linter msg - case of constants

IT LIVES

refactor to omit yucky explict return

update comments

Fix based on diff AccountProvider.has_account method

* Refactor flag name + don't change import_own_tx behaviour

fix arg name

Note: force commit to try and get gitlab tests working again 😠

* Add fn to TestMinerService

* Avoid race condition from trusted sources

- refactor the miner tests a bit to cut down on code reuse
- add `trusted` param to dispatch_transaction and import_claimed_local_transaction

Add param to `import_claimed_local_transaction`

Fix fn sig in tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Development

No branches or pull requests

4 participants