Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Cross-compiling docker images broken #9750

Closed
roderik opened this issue Oct 15, 2018 · 4 comments · Fixed by #9798
Closed

Cross-compiling docker images broken #9750

roderik opened this issue Oct 15, 2018 · 4 comments · Fixed by #9798
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M0-build 🏗 Building and build system. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone

Comments

@roderik
Copy link

roderik commented Oct 15, 2018

I'm trying to build a new docker container of parity (stable banch) with secretstore enabled.

I just duplicated the normal Dockerfile and added the --features secretstore flag to enable it. https://github.com/settlemint/parity-ethereum-secretstore/commit/44921d6588299f699b3b793e8d0d1e54cb0204bd

But it does not compile due to cannot find -ludev (full build log: https://gist.github.com/roderik/78f8b55ed28af833e0bb0fa3204c1949 on my mac)

Am I doing it wrong (or is there an official build with secretstore enabled ?)

@niklasad1
Copy link
Collaborator

niklasad1 commented Oct 15, 2018

hrm, it looks like the linker can't find libudev.so my guess that is not in the path LD_LIBRARY_PATH

I will try to verify this...

FYI, the flag secretstore should have no impact on this though

@Tbaut Tbaut added P5-sometimesoon 🌲 Issue is worth doing soon. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M0-build 🏗 Building and build system. labels Oct 15, 2018
@Tbaut Tbaut added this to the 2.2 milestone Oct 15, 2018
@roderik
Copy link
Author

roderik commented Oct 15, 2018

I understand you have priorities, but if you build a super cool feature and the build instructions required to use it do not work, i would suggest upping the priority a little bit :)

@niklasad1
Copy link
Collaborator

niklasad1 commented Oct 16, 2018

Yeah, I have verified that he docker image is bad, don't work with/without --features secretstore

I think the issue is that it tries to cross-compile and the cross-compiler's linker doesn't have libudev in its path/link to libudev.so. IMO, we need to compile or fetch a special library for aarch64 in this context. We should fix this

However, meanwhile you can use https://github.com/paritytech/scripts/blob/master/docker-files-for-Gitlab-CI-rust/cross/arm64/Dockerfile for aarch64

/cc @General-Beck @gabreal Thoughts?

@niklasad1 niklasad1 changed the title Compiling secretstore enabled docker containers fails Cross-compiling docker images broken Oct 16, 2018
@General-Beck
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M0-build 🏗 Building and build system. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants