-
Notifications
You must be signed in to change notification settings - Fork 1.7k
trace_filter does not return failed contract creation #9822
Comments
Is the trace also missing in I'm sure that the trace exists (etherscan has it, for example https://etherscan.io/vmtrace?txhash=0xb8965886e04cdbf18132a722f5a556a378b9dbcab5d1fc4050e54eadc12fafbd&type=parity#raw), this might be an issue regarding how trace_filter works as opposed to trace_block. |
Indeed, in
|
Seems the issue is here: https://github.com/paritytech/parity-ethereum/blob/9982eba1889cfc20e7a614da5e809b1dd4d8a729/ethcore/src/trace/types/filter.rs#L109 For some reason we return |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Foundation fund.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Workers have applied to start work. These users each claimed they can complete the work by 3 weeks, 2 days from now. 1) aashutoshrathi has applied to start work (Funders only: approve worker | reject worker). Check for the function where failed contract creation is handled, probably problem is with this as mentioned in the comment above. Learn more on the Gitcoin Issue Details page. |
@aashutoshrathi Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Hey @aashutoshrathi you're good to go on this, let us know if you have any questions! |
Is this bounty still open ? I'd love to help with it. @ceresstation |
@xiaods yes it's open, feel free to take it ;) |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 2 months, 3 weeks ago. 1) xiaods has been approved to start work. i currently maintain parity node and familiar with the parity apis. i can have a try to resolve it. thanks a lot. Learn more on the Gitcoin Issue Details page. |
trace_filter does not return failed contract creation openethereum#9822 reference @tomusdrw's comments on this issue: openethereum#9822 (comment) i have a try to fix it.
trace_filter does not return failed contract creation openethereum#9822 reference @tomusdrw's comments on this issue: openethereum#9822 (comment) i have a try to fix it.
@Tbaut cloud you approve my work request? |
trace_filter does not return failed contract creation openethereum#9822 reference @tomusdrw's comments on this issue: openethereum#9822 (comment) fix it.
@medvedev1088 cloud you approve my work request? |
…reation currently trace_filter can't return failed contract creation transaction but trace_block can query the failed contract creation transaction.it because the logic of parity-ethereum/ethcore/src/trace/types/filter.rs Line 109 in 9982eba ``` _ => false ``` this patch correct the logic: ``` _ => self.to_address.matches_all() ``` Signed-off-by: Deshi Xiao <xiaods@gmail.com>
I think @ceresstation can approve it. |
@ceresstation hi, cloud you please approve it? |
@xiaods Sorry for the delay, just approved you :) |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 60.0 DAI (60.0 USD @ $1.0/DAI) has been submitted by: @ceresstation please take a look at the submitted work:
|
@ceresstation when review done, it will merge asap. |
Superseded by #10140, it already mark as good. it will merge asap. |
@medvedev1088 you can check it. |
@ceresstation cloud you please check gitcoin task status? it already done. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @xiaods.
|
debug_trace
API for block 2,878,467 is missing the trace for transaction https://etherscan.io/tx/0xb8965886e04cdbf18132a722f5a556a378b9dbcab5d1fc4050e54eadc12fafbd. Is it an expected behaviour? If yes, what's the rationale for skipping such traces?Below is the JSON API request and response for the block.
The text was updated successfully, but these errors were encountered: