This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
chore(bump parity-daemonize): require rust >= 1.31 #10359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Feb 14, 2019
| @@ -195,7 +197,9 @@ fn main_direct(force_can_restart: bool) -> i32 { | |||
| conf.args.arg_chain = spec_override; | |||
| } | |||
|
|
|||
| let handle = if let Some(ref pid) = conf.args.arg_daemon_pid_file { | |||
| // FIXME: `pid_file` shouldn't need to cloned here | |||
| // see: `https://github.com/paritytech/parity-daemonize/pull/13` for more info | |||
There was a problem hiding this comment.
It shouldn't be a big deal, since only only do this once at startup and this string the issually small.
ordian
added
A8-looksgood 🦄
ascjones
approved these changes
Feb 18, 2019
ordian
added a commit
that referenced
this pull request
Apr 5, 2019
* master: Add message to IO errors (#10324) chore(bump parity-daemonize): require rust >= 1.31 (#10359) SecretStore: use in-memory transport in cluster tests (#9850) Add fields to `memzero`'s Cargo.toml (#10362) snap: release untagged versions from branches to the candidate snap channel (#10357) fix(compilation warns): `no-default-features` (#10346)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
parity-daemonizeto makeparitycompile with rustc 1.31.0 or later.Added a comment about a
clone()that was necessary to make it compile however it shouldn't be needed AFAIK!