This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Subdomains support in content server (webapps server). #1082
Merged
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// Copyright 2015, 2016 Ethcore (UK) Ltd. | ||
// This file is part of Parity. | ||
|
||
// Parity is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
//! Serving ProxyPac file | ||
|
||
use endpoint::{Endpoint, Handler, ContentHandler, EndpointPath}; | ||
use DAPPS_DOMAIN; | ||
|
||
pub struct ProxyPac; | ||
|
||
impl ProxyPac { | ||
pub fn boxed() -> Box<Endpoint> { | ||
Box::new(ProxyPac) | ||
} | ||
} | ||
|
||
impl Endpoint for ProxyPac { | ||
fn to_handler(&self, path: EndpointPath) -> Box<Handler> { | ||
let content = format!( | ||
r#" | ||
function FindProxyForURL(url, host) {{ | ||
if (shExpMatch(host, "*{0}")) | ||
{{ | ||
return "PROXY {1}:{2}"; | ||
}} | ||
|
||
return "DIRECT"; | ||
}} | ||
"#, | ||
DAPPS_DOMAIN, path.host, path.port); | ||
Box::new(ContentHandler::new(content, "application/javascript".to_owned())) | ||
} | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one
DAPPS_DOMAIN
? would probably be sensible to have a.parity
domain for inbuilt-parity stuff (which would use parity-specific RPCs) and.dapp
domain for theoretically standardised, cross-implementation stuff.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be easily extended to support more "domains", but we can still use addresses like:
http://status.parity.dapp
orhttp://myoracle.ethcore.dapp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah; i'm taking direction from the classic
about:
(and newerchrome:
) protocols which don't try to map overhttp:
but rather use a different namespace.i would reserve the
.dapp
domain for pages/packages which are, in principle, independent of parity..parity
could be used for our packages which are built in (i.e. all of them at present).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the domain to
.parity
(since we only have built-in dapps).Will prepare multi-domain support in separte PR.