Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix rlp decode for inline trie nodes. #10980

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Fix rlp decode for inline trie nodes. #10980

merged 3 commits into from
Aug 19, 2019

Conversation

cheme
Copy link
Contributor

@cheme cheme commented Aug 18, 2019

The test from #10972 last commit was incorrect, and fails on inline trie node.

@cheme cheme added A0-pleasereview 🤓 Pull request needs code review. A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 18, 2019
@cheme cheme added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Aug 18, 2019
@cheme cheme changed the title Fix rlp decode test for inline trie nodes. Fix rlp decode for inline trie nodes. Aug 18, 2019
dvdplm
dvdplm approved these changes Aug 19, 2019
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

(There's some funky whitespace here introduced by a previous PR I think).

Wrt to tests: should these tests not be in the main trie crate?

@dvdplm dvdplm requested a review from ordian August 19, 2019 07:40
ordian
ordian approved these changes Aug 19, 2019
View reviewed changes
Copy link
Collaborator

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I missed the last commit.

should these tests not be in the main trie crate?

No, they test NodeCodec impl for RlpNodeCodec.

util/patricia-trie-ethereum/src/lib.rs Outdated Show resolved Hide resolved
@ordian ordian added this to the 2.7 milestone Aug 19, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 19, 2019
@dvdplm dvdplm merged commit 0a654af into openethereum:master Aug 19, 2019
dvdplm added a commit that referenced this pull request Aug 20, 2019
@dvdplm
Merge branch 'master' into dp/chore/extract-spec-from-ethcore
79e6000 
* master:
  Fix rlp decode for inline trie nodes. (#10980)
  Private contract migration and offchain state sync (#10748)
  manual publish jobs for releases, no changes for nightlies (#10977)
dvdplm added a commit that referenced this pull request Aug 20, 2019
@dvdplm
Merge branch 'master' into dp/chore/sort-out-ClientIoMessage
6cd8b0d 
* master:
  Fix rlp decode for inline trie nodes. (#10980)
  Private contract migration and offchain state sync (#10748)
  manual publish jobs for releases, no changes for nightlies (#10977)
dvdplm added a commit that referenced this pull request Aug 21, 2019
@dvdplm
Merge branch 'master' into dp/chore/extract-clique
081e40e 
* master:
  Add a 2/3 quorum option to Authority Round. (#10909)
  Fix rlp decode for inline trie nodes. (#10980)
  Private contract migration and offchain state sync (#10748)
  manual publish jobs for releases, no changes for nightlies (#10977)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheme @dvdplm @ordian