This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
validate-chainspecs: check istanbul eips are in the foundation spec #11305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
M1-ci 🙉
dvdplm
approved these changes
Dec 5, 2019
niklasad1
reviewed
Dec 5, 2019
| @@ -15,6 +15,15 @@ done | |||
| for spec in ethcore/res/ethereum/*.json; do | |||
| if ! ./target/release/chainspec "$spec"; then ERR=1; fi | |||
| done | |||
|
|
|||
| echo "________Mainnet contains Istanbul EIPs________" | |||
| for eip in $(grep --only-matching "eip.*Transition" ethcore/res/ethereum/istanbul_test.json); do | |||
There was a problem hiding this comment.
how to deal with re-enable transitions?
There was a problem hiding this comment.
Add them to the chain spec?
#11228 (comment)
There was a problem hiding this comment.
yeah, I guess that is easiest solution even though they are redundant in this case.
niklasad1
reviewed
Dec 6, 2019
| @@ -15,6 +15,15 @@ done | |||
| for spec in ethcore/res/ethereum/*.json; do | |||
| if ! ./target/release/chainspec "$spec"; then ERR=1; fi | |||
| done | |||
|
|
|||
| echo "________Mainnet contains Istanbul EIPs________" | |||
There was a problem hiding this comment.
Doesn't have to be addressed in this PR but would be good to run this on the other testing network (hard forks) such as Contantinople and so on.
In order to make sure that we are not breaking anything.
There was a problem hiding this comment.
good point, but I think since we're running tests with istanbul_test spec, it should be caught there
niklasad1
approved these changes
Dec 6, 2019
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.