TX queue gas limit config and allow local transactions over the gas limit #2553

arkpar · 2016-10-10T12:39:06Z

coveralls · 2016-10-10T13:12:55Z

Coverage increased (+0.04%) to 86.408% when pulling dfe9916 on tx-queue-config into 271bcf4 on master.

coveralls · 2016-10-10T13:43:19Z

Coverage increased (+0.05%) to 86.419% when pulling c427b1f on tx-queue-config into 271bcf4 on master.

trapp · 2016-10-10T14:14:24Z

parity/cli/usage.txt

@@ -184,6 +184,10 @@ Sealing/Mining Options:
                           more than 32 characters. (default: {flag_extra_data:?})
  --tx-queue-size LIMIT    Maximum amount of transactions in the queue (waiting
                           to be included in next block) (default: {flag_tx_queue_size}).
+  --tx-queue-gas LIMIT     Maximum amount of total gas for external transactions in
+                           the queue. LIIMIT can be either an amont of gas or


Typo amont -> amount

tomusdrw · 2016-10-10T14:24:54Z

Shouldn't we propagate limited number of transactions (for instance blockgas*2) in case of --tx-queue-gas off?

arkpar · 2016-10-10T15:52:27Z

What about --tx-queue-gas 100000000?
Also local transaction should be sent out regardless of the limit.
Better fix would be to track previously sent transactions for each peer.
This is left for a future PR.

coveralls · 2016-10-10T16:47:29Z

Coverage increased (+0.03%) to 86.414% when pulling 21a8afe on tx-queue-config into 64f6f83 on master.

rphmeier · 2016-10-10T17:13:26Z

@arkpar We could track perviously-sent transactions for each peer (actually, it's considered Bad Form to send txs to the same peer more than once) but we have to be careful to limit the memory used while tracking this so the footprint of long-running nodes stays low.

trapp · 2016-10-10T17:15:01Z

We could track perviously-sent transactions for each peer

If you do something like this please don't forget to whitelist the peers from the --reserved-peers list for those limits.

[ci:skip]

…imit (#2553) * Gas limit config; Allow local transactions over the limit * Fix typo [ci:skip]

* TX queue gas limit config and allow local transactions over the gas limit (#2553) * Gas limit config; Allow local transactions over the limit * Fix typo [ci:skip] * v1.3.7

arkpar added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 10, 2016

arkpar force-pushed the tx-queue-config branch from dfe9916 to c427b1f Compare October 10, 2016 13:07

trapp reviewed Oct 10, 2016

View reviewed changes

Gas limit config; Allow local transactions over the limit

21a8afe

arkpar force-pushed the tx-queue-config branch from c427b1f to 21a8afe Compare October 10, 2016 15:52

Fix typo

05414a5

[ci:skip]

gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 10, 2016

gavofyork merged commit 26d7712 into master Oct 10, 2016

gavofyork deleted the tx-queue-config branch October 10, 2016 21:04

trapp mentioned this pull request Oct 12, 2016

eth_sendTransaction is dropping transactions #2547

Closed

arkpar added a commit that referenced this pull request Oct 12, 2016

TX queue gas limit config and allow local transactions over the gas l…

3f6b638

…imit (#2553) * Gas limit config; Allow local transactions over the limit * Fix typo [ci:skip]

arkpar added a commit that referenced this pull request Oct 12, 2016

Backports to beta (#2592)

1fdb033

* TX queue gas limit config and allow local transactions over the gas limit (#2553) * Gas limit config; Allow local transactions over the limit * Fix typo [ci:skip] * v1.3.7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TX queue gas limit config and allow local transactions over the gas limit #2553

TX queue gas limit config and allow local transactions over the gas limit #2553

arkpar commented Oct 10, 2016 •

edited

coveralls commented Oct 10, 2016

coveralls commented Oct 10, 2016

trapp Oct 10, 2016

tomusdrw commented Oct 10, 2016

arkpar commented Oct 10, 2016

coveralls commented Oct 10, 2016

rphmeier commented Oct 10, 2016

trapp commented Oct 10, 2016 •

edited

TX queue gas limit config and allow local transactions over the gas limit #2553

TX queue gas limit config and allow local transactions over the gas limit #2553

Conversation

arkpar commented Oct 10, 2016 • edited

coveralls commented Oct 10, 2016

coveralls commented Oct 10, 2016

trapp Oct 10, 2016

Choose a reason for hiding this comment

tomusdrw commented Oct 10, 2016

arkpar commented Oct 10, 2016

coveralls commented Oct 10, 2016

rphmeier commented Oct 10, 2016

trapp commented Oct 10, 2016 • edited

arkpar commented Oct 10, 2016 •

edited

trapp commented Oct 10, 2016 •

edited