This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Notify user when a transaction is received #2864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A3-inprogress ⏳
jacogr
reviewed
Oct 25, 2016
|
|
||
| Promise | ||
| .all([ | ||
| this._api.trace.filter({ |
There was a problem hiding this comment.
Why are we re-creating the filter with each block? We should just -
- create filter
- ask for updates on new block
There was a problem hiding this comment.
These are not the same filters as for the eth module. It's just the name of the function, which returns the filtered traces, but doesn't set up a proper filter to get changes from
ngotchac
changed the title
|
Closed in favor of #3782 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@see #2556
This is a WIP. Right now relies on the tracing mode enabled on the client.
There are no real ways to get accounts' transactions without it and without using a third party as Etherscan...