This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
EIPs 155, 160, 161 #2976
Merged
EIPs 155, 160, 161 #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-inprogress ⏳
gavofyork
added
A0-pleasereview 🤓
arkpar
reviewed
Oct 30, 2016
| @@ -72,8 +72,8 @@ pub struct Transaction { | |||
|
|
|||
| impl Transaction { | |||
| /// Append object with a without signature into RLP stream | |||
| pub fn rlp_append_unsigned_transaction(&self, s: &mut RlpStream) { | |||
| s.begin_list(6); | |||
| pub fn rlp_append_unsigned_transaction(&self, s: &mut RlpStream, network_id: Option<u8>) { | |||
There was a problem hiding this comment.
Should be made private so that it is not misused for RLP serialization
arkpar
reviewed
Oct 30, 2016
| @@ -295,8 +307,16 @@ impl SignedTransaction { | |||
| } | |||
| } | |||
|
|
|||
| /// 0 is `v` is 27, 1 if 28, and 4 otherwise. | |||
| pub fn standard_v(&self) -> u8 { match self.v { 27 => 0, 28 => 1, _ => 4 } } | |||
| /// 0 if `v` is 27, 1 if 28 or 4 if invalid. | |||
arkpar
added
A6-mustntgrumble 💦
gavofyork
added
A0-pleasereview 🤓
|
All these spec file keys are gonna be a bit hellish for users to migrate their private chains. |
rphmeier
reviewed
Oct 31, 2016
| Global, | ||
| Local(u8), | ||
| Either(u8), | ||
| } |
rphmeier
reviewed
Oct 31, 2016
| @@ -45,10 +50,20 @@ impl Substate { | |||
| /// Merge secondary substate `s` into self, accruing each element correspondingly. | |||
| pub fn accrue(&mut self, s: Substate) { | |||
| self.suicides.extend(s.suicides.into_iter()); | |||
| self.garbage.extend(s.garbage.into_iter()); | |||
There was a problem hiding this comment.
is it guaranteed that the union of two substates won't contain the same address in two sets?
There was a problem hiding this comment.
no, but then it also doesn't matter.
rphmeier
reviewed
Oct 31, 2016
| stream.out().sha3() | ||
| } | ||
|
|
||
| /// Signs the transaction as coming from `sender`. | ||
| pub fn sign(self, secret: &Secret) -> SignedTransaction { | ||
| let sig = ::ethkey::sign(secret, &self.hash()) | ||
| pub fn sign(self, secret: &Secret, network_id: Option<u8>) -> SignedTransaction { |
There was a problem hiding this comment.
a convenience function sign_standard = sign(secret, None) would be nice.
There was a problem hiding this comment.
sign_standard would be a misnomer since not providing a network ID is not a "standard" - could be sign_without_network_id, but then i think sign(..., None) says mostly the same without the verbosity and additional fn.
|
re: private chains, yeah - it's not our fault, though. @keorn has a script to help with this. |
rphmeier
reviewed
Nov 1, 2016
| ChainEra::TransitionTest => ethereum::new_transition_test().engine, | ||
| }; | ||
|
|
||
| for (name, test) in tests.into_iter() { | ||
| /* if name != "ZeroValue_SUICIDE" { | ||
| continue; | ||
| }*/ |
arkpar
added
A8-looksgood 🦄
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components: