Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Use signature of functions instead of names #3448

Merged
merged 2 commits into from
Nov 15, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions js/src/api/contract/contract.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,12 @@ export default class Contract {

this._events.forEach((evt) => {
this._instance[evt.name] = evt;
this._instance[evt.signature] = evt;
});

this._functions.forEach((fn) => {
this._instance[fn.name] = fn;
this._instance[fn.signature] = fn;
});

this._sendSubscriptionChanges();
Expand Down
9 changes: 8 additions & 1 deletion js/src/api/contract/contract.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import sinon from 'sinon';
import { TEST_HTTP_URL, mockHttp } from '../../../test/mockRpc';

import Abi from '../../abi';
import { sha3 } from '../util/sha3';

import Api from '../api';
import Contract from './contract';
Expand Down Expand Up @@ -113,7 +114,13 @@ describe('api/contract/Contract', () => {
]);
contract.at('6789');

expect(Object.keys(contract.instance)).to.deep.equal(['Drained', 'balanceOf', 'address']);
expect(Object.keys(contract.instance)).to.deep.equal([
'Drained',
/^(?:0x)(.+)$/.exec(sha3('Drained(uint256)'))[1],
'balanceOf',
/^(?:0x)(.+)$/.exec(sha3('balanceOf(address)'))[1].substr(0, 8),
'address'
]);
expect(contract.address).to.equal('6789');
});
});
Expand Down
5 changes: 3 additions & 2 deletions js/src/views/Contract/Queries/inputQuery.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export default class InputQuery extends Component {
inputs: PropTypes.array.isRequired,
outputs: PropTypes.array.isRequired,
name: PropTypes.string.isRequired,
signature: PropTypes.string.isRequired,
className: PropTypes.string
}

Expand Down Expand Up @@ -177,7 +178,7 @@ export default class InputQuery extends Component {

onClick = () => {
const { values } = this.state;
const { inputs, contract, name, outputs } = this.props;
const { inputs, contract, name, outputs, signature } = this.props;

this.setState({
isLoading: true,
Expand All @@ -187,7 +188,7 @@ export default class InputQuery extends Component {
const inputValues = inputs.map(input => values[input.name]);

contract
.instance[name]
.instance[signature]
.call({}, inputValues)
.then(results => {
if (outputs.length === 1) {
Expand Down
3 changes: 2 additions & 1 deletion js/src/views/Contract/Queries/queries.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default class Queries extends Component {
}

renderInputQuery (fn) {
const { abi, name } = fn;
const { abi, name, signature } = fn;
const { contract } = this.props;

return (
Expand All @@ -80,6 +80,7 @@ export default class Queries extends Component {
inputs={ abi.inputs }
outputs={ abi.outputs }
name={ name }
signature={ signature }
contract={ contract }
/>
</div>
Expand Down