This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Light server improvements and protocol adjustments #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
rphmeier
commented
Dec 10, 2016
| let mut stream = RlpStream::new_list(request.block_hashes.len() + 1); | ||
| stream.append(&req_id); | ||
| let mut stream = RlpStream::new_list(2); | ||
| stream.append(&req_id).begin_list(request.block_hashes.len()); |
There was a problem hiding this comment.
Spec has been changed so that all requests and responses will have a variable-length list as the last item rather than having the root list be variable-length.
(personally not the way that I would go about it but geth's behavior was not per the spec and I wanted to test the server with its light client)
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geth light client can now sync ropsten using parity peers:
Mainnet is a bit more complicated since we don't support the hardcoded CHT which geth expects.