This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
UI component updates #4010
Merged
UI component updates #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A1-onice 🌨
ngotchac
reviewed
Jan 4, 2017
| : <FormattedMessage | ||
| id='ui.txHash.confirmations' | ||
| defaultMessage='{count} confirmations' | ||
| values={ { count } } /> |
There was a problem hiding this comment.
Isn't there something for formatting variations based on singular/plurals/etc. ? This binary 1 vs. many won't work in some other languages
There was a problem hiding this comment.
I guess this is a more general problem with our i18n setup.
There was a problem hiding this comment.
There is native support in react-intl, honestly I cannot quite remember how it works, but will take a look and update accordingly.
ngotchac
added
A6-mustntgrumble 💦
|
One small comment. Looks good otherwise. |
ngotchac
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not critical for 1.5 merge.