Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Backporting to beta #4118

Merged
merged 5 commits into from
Jan 11, 2017
Merged

Backporting to beta #4118

merged 5 commits into from
Jan 11, 2017

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Jan 10, 2017

No description provided.

gavofyork and others added 3 commits January 10, 2017 19:04
* Auto-detect hex encoded bytes in sha3

* Using types/isHex

* Removing unused imports
* Initial sketch.

* Building.

* Fix a few things.

* Fix issue, add tracing.

* Address grumbles

* Raise upper limit if needed

* Fix test.
@arkpar arkpar added A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust. labels Jan 10, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f738dcf on backporting into ** on beta**.

@gavofyork
Copy link
Contributor

@keorn - are they your tests there which are failing?

@keorn
Copy link

keorn commented Jan 11, 2017

Yes, its caused here https://github.com/ethcore/parity/pull/4100 call_contract returns error

Execution(BlockGasLimitReached { gas_limit: 3141592, gas_used: 0, gas: 50000000 })

I think resolved with @arkpar

tomusdrw and others added 2 commits January 11, 2017 14:31
* Return 0 instead of error with out of gas on estimate_gas

* Fix stuff up.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d88d4b0 on backporting into ** on beta**.

@gavofyork gavofyork merged commit 5e70507 into beta Jan 11, 2017
@gavofyork gavofyork deleted the backporting branch January 11, 2017 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants