This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
web browser dapp: prompt to install extension #4412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
added
A3-inprogress ⏳
|
Closing in favour of https://github.com/ethcore/parity/pull/4423 which takes this logic to implement an application-wide prompt as opposed to a Web dapp flavoured version (This PR did most of the heavy lifting install-related stuff already, so logic is 99.9% based on this). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4300. Tries inline installation first, falls back to opening a popup with the Chrome Web Store.
Will need a better description why to install the extension.