Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

SMS Faucet #4774

Merged
merged 16 commits into from Mar 7, 2017
Merged

SMS Faucet #4774

merged 16 commits into from Mar 7, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Mar 5, 2017

parity 2017-03-05 20-04-13
parity 2017-03-07 08-20-54
parity 2017-03-07 08-26-56
parity 2017-03-07 17-40-32

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Mar 5, 2017
Copy link
Collaborator

@bjornwgnr bjornwgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos in: "Request Kovan ETH from the faucet by executing the transfer for am sms-verified Foumdation address."

PS: can't edit myself bc I have no push access to this branch

@jacogr jacogr removed the B0-patch label Mar 6, 2017
@jacogr
Copy link
Contributor Author

jacogr commented Mar 7, 2017

@bjornwgnr Sure. Simplified quite a bit since then to work with the new endpoints - with the welcome addition that that issue has also gone the way of the dodo.

@jacogr jacogr added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Mar 7, 2017
@jacogr jacogr removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Mar 7, 2017
@jacogr jacogr added B0-patch A0-pleasereview 🤓 Pull request needs code review. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 7, 2017
@jacogr
Copy link
Contributor Author

jacogr commented Mar 7, 2017

Merging as-is, tested across homestead, ropsten & kovan.

@jacogr jacogr merged commit c3c8308 into master Mar 7, 2017
@jacogr jacogr deleted the jg-faucet branch March 7, 2017 19:21
jacogr added a commit that referenced this pull request Mar 7, 2017
* Faucet

* Remove flakey button-index testing

* Only display faucet when sms verified (mainnet)

* simplify availability checks

* WIP

* Resuest from verified -> verified

* Update endpoint, display response text

* Error icon on errors

* Parse hash text response

* Use /api/:address endpoint

* hash -> data

* Adjust sms-certified message
@jacogr jacogr mentioned this pull request Mar 7, 2017
arkpar pushed a commit that referenced this pull request Mar 8, 2017
* Update Wallet to new Wallet Code (#4805)

* Update Wallet Version

* Update Wallet Library

* Update Wallets Bytecodes

* Typo

* Separate Deploy in Contract API

* Use the new Wallet ABI // Update wallet code

* WIP .// Deploy from Wallet

* Update Wallet contract

* Contract Deployment for Wallet

* Working deployments for Single Owned Wallet contracts

* Linting

* Create a Wallet from a Wallet

* Linting

* Fix Signer transactions // Add Gas Used for transactions

* Deploy wallet contract fix

* Fix too high gas estimate for Wallet Contract Deploys

* Final piece ; deploying from Wallet owned by wallet

* Update Wallet Code

* Updated the Wallet Codes

* Fixing Wallet Deployments

* Add Support for older wallets

* Linting

* SMS Faucet (#4774)

* Faucet

* Remove flakey button-index testing

* Only display faucet when sms verified (mainnet)

* simplify availability checks

* WIP

* Resuest from verified -> verified

* Update endpoint, display response text

* Error icon on errors

* Parse hash text response

* Use /api/:address endpoint

* hash -> data

* Adjust sms-certified message

* Fix SectionList hovering issue (#4749)

* Fix SectionList Items hover when <3 items

* Even easier...

* lint (new)
@rstormsf
Copy link

rstormsf commented Apr 27, 2017

@jacogr
I just installed from master:
brew install parity --master
and I was still getting this notification that my account needs to be verified when I was trying to get KOVAN eth
Parity/1.7.0/1.16.0/ma

I also filed this bug: #5517

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants