This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Strict validation transitions #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keorn
added
A0-pleasereview 🤓
arkpar
reviewed
Mar 26, 2017
| @@ -64,6 +66,7 @@ impl From<ethjson::spec::AuthorityRoundParams> for AuthorityRoundParams { | |||
| block_reward: p.block_reward.map_or_else(U256::zero, Into::into), | |||
| registrar: p.registrar.map_or_else(Address::new, Into::into), | |||
| start_step: p.start_step.map(Into::into), | |||
| validate_score_transition: p.validate_score_transition.map_or(0, Into::into), | |||
There was a problem hiding this comment.
Does the default at 0 break compatibility with existing PoA chains?
There was a problem hiding this comment.
Only ones started with 1.5, but the default eip98 transition breaks them anyway.
|
Needs a rebase |
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Apr 10, 2017
* ability to make validation stricter * fix consensus * remove logger
arkpar
added a commit
that referenced
this pull request
Apr 10, 2017
* v1.6.6 * Strict validation transitions (#4988) * ability to make validation stricter * fix consensus * remove logger * Fix eth_sign showing as wallet account (#5309) * defaultProps for account * Pass signing account * Update tests for Connect(...) * Add new seed nodes (#5345) * Kovan warp sync fixed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.