-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Better memory management #516
Conversation
impl Default for BlockQueueConfig { | ||
fn default() -> Self { | ||
BlockQueueConfig { | ||
max_queue_size: 30000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No test proof that this options are actually working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test added
@@ -220,33 +238,7 @@ const COLLECTION_QUEUE_SIZE: usize = 8; | |||
|
|||
impl BlockChain { | |||
/// Create new instance of blockchain from given Genesis | |||
/// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BlockChain is no longer part of the public crate interface
@@ -58,6 +58,8 @@ pub struct Spec { | |||
|
|||
/// Known nodes on the network in enode format. | |||
pub nodes: Vec<String>, | |||
/// Network ID | |||
pub network_id: U256, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this come from? should it be part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I've added a number of configuration options in this PR, and that's one of them.
No description provided.