Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Network tracing cleanup #611

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Network tracing cleanup #611

merged 1 commit into from
Mar 7, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Mar 5, 2016

fixes #538

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Mar 5, 2016
@@ -170,29 +170,37 @@ pub struct NetworkContext<'s, Message> where Message: Send + Sync + Clone + 'sta
io: &'s IoContext<NetworkIoMessage<Message>>,
protocol: ProtocolId,
sessions: Arc<RwLock<Slab<SharedSession>>>,
session: Option<StreamToken>,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared session pointer is used to output proper client id instead of "unknown" on disconnect and to guarantee that io handler is dealing with the same session.

@gavofyork
Copy link
Contributor

code quality looks fine but i'm not familiar enough with this part of the codebase to sign off on the logic.

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 6, 2016
arkpar added a commit that referenced this pull request Mar 7, 2016
@arkpar arkpar merged commit 7e9f137 into master Mar 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear up Token registration problems
3 participants