Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix double initialization of embeded providers. #7326

Merged
merged 2 commits into from
Dec 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion js/src/embed.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,16 @@ class FrameSecureApi extends SecureApi {
() => transport,
() => 'http:'
);

this._isConnected = false;
}

connect () {
// Do nothing - this API does not need connecting
this.emit('connecting');
// Fire connected event with some delay.
setTimeout(() => {
this._isConnected = true;
this.emit('connected');
});
}
Expand All @@ -86,7 +89,7 @@ class FrameSecureApi extends SecureApi {
}

isConnected () {
return true;
return this._isConnected;
}
}

Expand Down
2 changes: 1 addition & 1 deletion js/webpack/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = {
cache: !isProd,
devtool: isProd
? false
: '#eval',
: isEmbed ? '#source-map' : '#eval',
context: path.join(__dirname, '../src'),
entry,
output: {
Expand Down