Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Sync fixed again #737

Merged
merged 2 commits into from
Mar 15, 2016
Merged

Sync fixed again #737

merged 2 commits into from
Mar 15, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Mar 15, 2016

fixes #730, #728, and probably #727

@@ -498,9 +501,10 @@ impl ChainSync {
Ok(_) => {
if self.current_base_block() < header.number {
self.last_imported_block = Some(header.number);
self.last_imported_hash = Some(header.hash());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the main problem. Just forgot to update last_imported_hash here

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Mar 15, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 15, 2016
gavofyork added a commit that referenced this pull request Mar 15, 2016
@gavofyork gavofyork merged commit b0f233a into master Mar 15, 2016
@gavofyork gavofyork deleted the sync branch March 15, 2016 11:13
gavofyork added a commit that referenced this pull request Mar 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync hanged on zhadum.parity.io @ #565333 after ancient block imported
2 participants