Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fork choice and metadata framework for Engine #8401

Merged
merged 73 commits into from
May 16, 2018
Merged

Fork choice and metadata framework for Engine #8401

merged 73 commits into from
May 16, 2018

Commits on Apr 13, 2018

  1. Add light client TODO item

    @sorpaas
    sorpaas committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    b07ad5f View commit details
    Browse the repository at this point in the history

  2. Move existing total-difficulty-based fork choice check to Engine

    @sorpaas
    sorpaas committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    3c891b9 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2018

  1. Abstract total difficulty and block provider as Machine::BlockMetadat… 

    …a and Machine::BlockProvider
    @sorpaas
    sorpaas committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    d272376 View commit details
    Browse the repository at this point in the history

  2. Decouple "generate_metadata" logic to Engine

    @sorpaas
    sorpaas committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    c4d349c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fork-choice-no-metadata

    @sorpaas
    sorpaas committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    e1c0252 View commit details
    Browse the repository at this point in the history

  4. Use fixed BlockMetadata and BlockProvider type for null and instantseal 

    In this way they can use total difficulty fork choice check
    @sorpaas
    sorpaas committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    1d8149a View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2018

  1. Extend blockdetails with metadatas and finalized info

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    d3ef877 View commit details
    Browse the repository at this point in the history

  2. Extra data update: mark_finalized and update_metadatas

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    f325298 View commit details
    Browse the repository at this point in the history

  3. Check finalized block in Blockchain

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    6756cef View commit details
    Browse the repository at this point in the history

  4. Fix a test constructor in verification mod

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    7c958b4 View commit details
    Browse the repository at this point in the history

  5. Add total difficulty trait

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    e491abf View commit details
    Browse the repository at this point in the history

  6. Fix type import

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    5459695 View commit details
    Browse the repository at this point in the history

  7. Db migration to V13 with metadata column

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    7fe0d79 View commit details
    Browse the repository at this point in the history

  8. Address grumbles

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    ce105c6 View commit details
    Browse the repository at this point in the history

  9. metadatas -> metadata

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    45b8ce7 View commit details
    Browse the repository at this point in the history

  10. Use generic type for update_metadata to avoid passing HashMap all around

    @sorpaas
    sorpaas committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    f86d4cf View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. Merge branch 'finalize' into fork-choice-no-metadata

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    24b6316 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/parity into fo… 

    …rk-choice-no-metadata
    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    e797462 View commit details
    Browse the repository at this point in the history

  3. Remove metadata in blockdetails

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    c6dd811 View commit details
    Browse the repository at this point in the history

  4. [WIP] Implement a generic metadata architecture

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    fb1cc21 View commit details
    Browse the repository at this point in the history

  5. [WIP] Metadata insertion logic in BlockChain

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    5cb6813 View commit details
    Browse the repository at this point in the history

  6. typo: Value -> Self::Value

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    f972609 View commit details
    Browse the repository at this point in the history

  7. [WIP] Temporarily remove Engine::is_new_best interface 

    So that we don't have too many type errors.
    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    493e6f0 View commit details
    Browse the repository at this point in the history

  8. [WIP] Fix more type errors

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    cb5bfcf View commit details
    Browse the repository at this point in the history

  9. [WIP] ExtendedHeader::PartialEq

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    fc809c7 View commit details
    Browse the repository at this point in the history

  10. [WIP] Change metadata type Option<Vec<u8>> to Vec<u8>

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    d517ba3 View commit details
    Browse the repository at this point in the history

  11. [WIP] Remove Metadata Error

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    ac37c31 View commit details
    Browse the repository at this point in the history

  12. [WIP] Clean up error conversion

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    0f36e50 View commit details
    Browse the repository at this point in the history

  13. [WIP] finalized -> is_finalized

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    ef3aa63 View commit details
    Browse the repository at this point in the history

  14. [WIP] Mark all fields in ExtrasInsert as pub

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    3957c49 View commit details
    Browse the repository at this point in the history

  15. [WIP] Remove unused import

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    bc9cc87 View commit details
    Browse the repository at this point in the history

  16. [WIP] Keep only local metadata info

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    4983b68 View commit details
    Browse the repository at this point in the history

  17. Mark metadata as optional

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    6009dfa View commit details
    Browse the repository at this point in the history

  18. [WIP] Revert metadata db change in BlockChain

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    13b1b5b View commit details
    Browse the repository at this point in the history

  19. [WIP] Put finalization in unclosed state

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    723e8a9 View commit details
    Browse the repository at this point in the history

  20. Use metadata interface in BlockDetail

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    cf34f0d View commit details
    Browse the repository at this point in the history

  21. [WIP] Fix current build failures

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    5861acb View commit details
    Browse the repository at this point in the history

  22. [WIP] Remove unused blockmetadata struct

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    6d68222 View commit details
    Browse the repository at this point in the history

  23. Remove DB migration info

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    a492830 View commit details
    Browse the repository at this point in the history

  24. [WIP] Typo

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    8a06c4e View commit details
    Browse the repository at this point in the history

  25. Use ExtendedHeader to implement fork choice check

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    e673a98 View commit details
    Browse the repository at this point in the history

  26. Implement is_new_best using Ancestry iterator

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    700779e View commit details
    Browse the repository at this point in the history

  27. Use expect instead of panic

    @sorpaas
    sorpaas committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    143277f View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. [WIP] Add ancestry Engine support via on_new_block

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    1dd2ea1 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    5d4bd67 View commit details
    Browse the repository at this point in the history

  3. Emission of ancestry actions

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    704e697 View commit details
    Browse the repository at this point in the history

  4. use_short_version should take account of metadata

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    fdadd42 View commit details
    Browse the repository at this point in the history

  5. Engine::is_new_best -> Engine::fork_choice

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    60a7a17 View commit details
    Browse the repository at this point in the history

  6. Use proper expect format as defined in openethereum#1026

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    78569a0 View commit details
    Browse the repository at this point in the history

  7. panic -> expect

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    8d6629b View commit details
    Browse the repository at this point in the history

  8. ancestry_header -> ancestry_with_metadata

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    fda5e75 View commit details
    Browse the repository at this point in the history

  9. Boxed iterator -> &mut iterator

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    45f144d View commit details
    Browse the repository at this point in the history

  10. Fix tests

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    86d1ef2 View commit details
    Browse the repository at this point in the history

  11. is_new_best -> primitive_fork_choice

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    7281726 View commit details
    Browse the repository at this point in the history

  12. Document how fork_choice works

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    d86a056 View commit details
    Browse the repository at this point in the history

  13. Engine::fork_choice -> Engine::primitive_fork_choice

    @sorpaas
    sorpaas committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    e7a83f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. comment: clarify types of finalization where Engine::primitive_fork_c… 

    …hoice works
    @sorpaas
    sorpaas committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    6b6b042 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/parity into fo… 

    …rk-choice-no-metadata
    @sorpaas
    sorpaas committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    d36e41f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2018

  1. Expose FinalizationInfo to Engine

    @sorpaas
    sorpaas committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    c593e17 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/parity into fo… 

    …rk-choice-no-metadata
    @sorpaas
    sorpaas committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    4900e86 View commit details
    Browse the repository at this point in the history

  3. Fix tests due to merging

    @sorpaas
    sorpaas committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    0b8e55d View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2018

  1. Merge branch 'master' into fork-choice-no-metadata

    @sorpaas
    sorpaas committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    4512b09 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. Remove TotalDifficulty trait

    @sorpaas
    sorpaas committed May 1, 2018
    Configuration menu
    Copy the full SHA
    69cc856 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. Merge branch 'master' of https://github.com/paritytech/parity into fo… 

    …rk-choice-no-metadata
    @sorpaas
    sorpaas committed May 8, 2018
    Configuration menu
    Copy the full SHA
    4df05f0 View commit details
    Browse the repository at this point in the history

  2. Do not pass FinalizationInfo to Engine 

    If there's finalized blocks in from route, choose the old branch without calling `Engine::fork_choice`.
    @sorpaas
    sorpaas committed May 8, 2018
    Configuration menu
    Copy the full SHA
    60b6def View commit details
    Browse the repository at this point in the history

Commits on May 9, 2018

  1. Merge branch 'master' of https://github.com/paritytech/parity into fo… 

    …rk-choice-no-metadata
    @sorpaas
    sorpaas committed May 9, 2018
    Configuration menu
    Copy the full SHA
    fca4ca1 View commit details
    Browse the repository at this point in the history

  2. Fix compile

    @sorpaas
    sorpaas committed May 9, 2018
    Configuration menu
    Copy the full SHA
    15a967b View commit details
    Browse the repository at this point in the history

  3. Fix unused import

    @sorpaas
    sorpaas committed May 9, 2018
    Configuration menu
    Copy the full SHA
    8d1d98b View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Remove is_to_route_finalized 

    When no block reorg passes a finalized block, this variable is always false.
    @sorpaas
    sorpaas committed May 11, 2018
    Configuration menu
    Copy the full SHA
    63a3f54 View commit details
    Browse the repository at this point in the history

  2. Address format grumbles

    @sorpaas
    sorpaas committed May 11, 2018
    Configuration menu
    Copy the full SHA
    7b0cd66 View commit details
    Browse the repository at this point in the history

  3. Fix docs: mark_finalized returns None if block hash is not found 

    `blockchain` mod does not yet have an Error type, so we still temporarily use None here.
    @sorpaas
    sorpaas committed May 11, 2018
    Configuration menu
    Copy the full SHA
    2c17071 View commit details
    Browse the repository at this point in the history

  4. Fix inaccurate tree_route None expect description

    @sorpaas
    sorpaas committed May 11, 2018
    Configuration menu
    Copy the full SHA
    819b3d8 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Merge branch 'master' of https://github.com/paritytech/parity into fo… 

    …rk-choice-no-metadata
    @sorpaas
    sorpaas committed May 14, 2018
    Configuration menu
    Copy the full SHA
    58756e4 View commit details
    Browse the repository at this point in the history