This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Refactor EIP150, EIP160 and EIP161 forks to be specified in CommonParams #8614
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7962a7f
Allow post-homestead forks to be specified in CommonParams
sorpaas c869d8b
Fix all json configs
sorpaas 1deb228
Fix test in json crate
sorpaas d9bf350
Fix test in ethcore
sorpaas fef5d90
Fix all chain configs to use tabs
sorpaas File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,6 @@ | |
"durationLimit":"0x0d", | ||
"homesteadTransition":"0x118c30", | ||
"eip100bTransition":"0x7fffffffffffff", | ||
"eip150Transition":"0x7fffffffffffff", | ||
"eip160Transition":"0x7fffffffffffff", | ||
"eip161abcTransition":"0x7fffffffffffff", | ||
"eip161dTransition":"0x7fffffffffffff", | ||
"eip649Transition":"0x7fffffffffffff", | ||
"blockReward":"0x1105a0185b50a80000", | ||
"mcip3Transition":"0x00", | ||
|
@@ -33,6 +29,10 @@ | |
"networkID":"0x76740b", | ||
"forkBlock":"0x5b6", | ||
"forkCanonHash":"0xa5e88ad9e34d113e264e307bc27e8471452c8fc13780324bb3abb96fd0558343", | ||
"eip150Transition":"0x7fffffffffffff", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. inconsistent indentation ;) |
||
"eip160Transition":"0x7fffffffffffff", | ||
"eip161abcTransition":"0x7fffffffffffff", | ||
"eip161dTransition":"0x7fffffffffffff", | ||
"eip86Transition":"0x7fffffffffffff", | ||
"eip98Transition":"0x7fffffffffffff", | ||
"eip140Transition":"0x7fffffffffffff", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,6 @@ | |
"durationLimit":"0x0d", | ||
"homesteadTransition":"0x17", | ||
"eip100bTransition":"0x2a", | ||
"eip150Transition":"0x2a", | ||
"eip160Transition":"0x7fffffffffffff", | ||
"eip161abcTransition":"0x7fffffffffffff", | ||
"eip161dTransition":"0x7fffffffffffff", | ||
"eip649Transition":"0x2a", | ||
"blockReward":"0x1105a0185b50a80000", | ||
"mcip3Transition":"0x17", | ||
|
@@ -33,6 +29,10 @@ | |
"networkID":"0x76740c", | ||
"forkBlock":"0x2b", | ||
"forkCanonHash":"0x23c3171e864a5d513a3ef85e4cf86dac4cc36b89e5b8e63bf0ebcca68b9e43c9", | ||
"eip150Transition":"0x2a", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. inconsistent indentation ;) |
||
"eip160Transition":"0x7fffffffffffff", | ||
"eip161abcTransition":"0x7fffffffffffff", | ||
"eip161dTransition":"0x7fffffffffffff", | ||
"eip86Transition":"0x7fffffffffffff", | ||
"eip98Transition":"0x7fffffffffffff", | ||
"eip140Transition":"0x2a", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,6 @@ | |
"durationLimit":"0x0d", | ||
"homesteadTransition":"0x118c30", | ||
"eip100bTransition":"0x21e88e", | ||
"eip150Transition":"0x21e88e", | ||
"eip160Transition":"0x21e88e", | ||
"eip161abcTransition":"0x21e88e", | ||
"eip161dTransition":"0x21e88e", | ||
"eip649Transition":"0x21e88e", | ||
"blockReward":"0x1105a0185b50a80000", | ||
"mcip3Transition":"0x124f81", | ||
|
@@ -33,6 +29,10 @@ | |
"networkID":"0x76740f", | ||
"forkBlock":"0x1d8015", | ||
"forkCanonHash":"0x380602acf82b629a0be6b5adb2b4a801e960a07dc8261bf196d21befdbb8f2f9", | ||
"eip150Transition":"0x21e88e", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. inconsistent indentation ;) |
||
"eip160Transition":"0x21e88e", | ||
"eip161abcTransition":"0x21e88e", | ||
"eip161dTransition":"0x21e88e", | ||
"eip86Transition":"0x7fffffffffffff", | ||
"eip98Transition":"0x7fffffffffffff", | ||
"eip140Transition":"0x21e88e", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent indentation ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to fix all spec configs to use tabs instead of spaces given that's what's stated in
.editorconfig
, and the majority of our spec configs are tabbed.