Skip to content

Commit

Permalink
soundwire: bus: add better dev_dbg to track complete() calls
Browse files Browse the repository at this point in the history
stable inclusion
from stable-v5.10.190
commit 662735bc11279f474c8abfd6c8d4faeddd08f359
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I928UI

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=662735bc11279f474c8abfd6c8d4faeddd08f359

--------------------------------

[ Upstream commit f1b6902 ]

Add a dev_dbg() log for both enumeration and initialization completion
to better track suspend-resume issues.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210126085402.4264-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Stable-dep-of: c40d6b3 ("soundwire: fix enumeration completion")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: sanglipeng <sanglipeng1@jd.com>
  • Loading branch information
plbossart authored and sanglipeng1 committed Feb 22, 2024
1 parent 62c5971 commit 990fc36
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/soundwire/bus.c
Expand Up @@ -797,7 +797,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,

if (status == SDW_SLAVE_UNATTACHED) {
dev_dbg(&slave->dev,
"%s: initializing completion for Slave %d\n",
"%s: initializing enumeration and init completion for Slave %d\n",
__func__, slave->dev_num);

init_completion(&slave->enumeration_complete);
Expand All @@ -806,7 +806,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
} else if ((status == SDW_SLAVE_ATTACHED) &&
(slave->status == SDW_SLAVE_UNATTACHED)) {
dev_dbg(&slave->dev,
"%s: signaling completion for Slave %d\n",
"%s: signaling enumeration completion for Slave %d\n",
__func__, slave->dev_num);

complete(&slave->enumeration_complete);
Expand Down Expand Up @@ -1734,8 +1734,13 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
if (ret)
dev_err(slave->bus->dev,
"Update Slave status failed:%d\n", ret);
if (attached_initializing)
if (attached_initializing) {
dev_dbg(&slave->dev,
"%s: signaling initialization completion for Slave %d\n",
__func__, slave->dev_num);

complete(&slave->initialization_complete);
}
}

return ret;
Expand Down

0 comments on commit 990fc36

Please sign in to comment.