Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this supposed to be a base theme? #7

Closed
pfrenssen opened this issue Jun 24, 2021 · 2 comments
Closed

Is this supposed to be a base theme? #7

pfrenssen opened this issue Jun 24, 2021 · 2 comments

Comments

@pfrenssen
Copy link
Member

We have been instructed to use this as the basis for the new Joinup theme. However it is not clear how this can be used, since this is not marked as a base theme in oe_bootstrap_theme.info.yml. Is this supposed to be a full theme that should not be extended by projects? Or is this simply a mistake and the intention is for this to be a base theme?

@claudiu-cristea
Copy link
Contributor

claudiu-cristea commented Jun 24, 2021

Any full theme can be a base theme. Only the sub-theme should have a reference to the theme that it extends, by using the base theme: key.

@pfrenssen
Copy link
Member Author

Ah yes you're right, I see this option now documented on https://www.drupal.org/docs/theming-drupal/defining-a-theme-with-an-infoyml-file#base-theme - I was not aware of this usage of setting it to FALSE. Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants