ISAICP-6538: Rename EUA to OE Bootstrap Theme #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrenssen
previously approved these changes
Jun 10, 2021
vever001
suggested changes
Jun 11, 2021
oe_bootstrap_theme.libraries.yml
Outdated
| @@ -1,10 +1,10 @@ | |||
| style: | |||
| version: VERSION | |||
| js: | |||
| assets/js/eua.script.js: {} | |||
| assets/js/oe_boostrap_theme.script.js: {} | |||
There was a problem hiding this comment.
Typo, missing t: oe_boostrap_theme > oe_bootstrap_theme
oe_bootstrap_theme.libraries.yml
Outdated
| css: | ||
| theme: | ||
| assets/css/eua.style.css: {} | ||
| assets/css/oe_boostrap_theme.style.css: {} |
There was a problem hiding this comment.
Typo, missing t: oe_boostrap_theme > oe_bootstrap_theme
| @@ -1,16 +1,16 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Same here for the filename, class and usages:
- OpenEuropaBoostrapThemePreRender.php > OpenEuropaBootstrapThemePreRender.php
- class OpenEuropaBoostrapThemePreRender > class OpenEuropaBootstrapThemePreRender
- and calls to that class
|
@vever001 it seems that I was hungry and I ate that "t" :) Fixed the remarks, thank you |
idimopoulos
approved these changes
Jun 14, 2021
julien-
pushed a commit
to julien-/oe_bootstrap_theme
that referenced
this pull request
Feb 23, 2024
Update local branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Jira issue(s):