OEL-522: Drop Components module, use ECL Twig loader #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiu-cristea
force-pushed
the
OEL-522
branch
3 times, most recently
from
008aba0
to
6d7a708
Compare
drishu
requested changes
Dec 6, 2021
modules/oe_bootstrap_theme_helper/tests/src/Kernel/BclComponentsOverrideTest.php
Show resolved
Hide resolved
package.json
Outdated
| "watch:styles": "chokidar \"./resources/sass/**/*.scss\" -i \"/node_modules/\" -c \"npm run build:styles\"", | ||
| "watch": "npm-run-all --parallel watch:* -ln", | ||
| "postinstall": "npm-run-all build:*", | ||
| "production": "npm-run-all build:*" | ||
| }, | ||
| "devDependencies": { | ||
| "@openeuropa/bcl-builder": "0.11.0", | ||
| "@openeuropa/bcl-theme-default": "0.11.0", | ||
| "@openeuropa/bcl-builder": "^0.12.0", |
We prefix component names with 'bcl-' so they will never overlap with the templates inside 'templates/'.
When building the codebase, npm install and composer install shouldn't depend one on the other. They should be able to run in parallel. But composer install creates also the symlinks inside the 'build/' directory, so 'assets/' directory should be already there, in the case composer install runs first.
brummbar
approved these changes
Dec 10, 2021
drishu
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #91 (somehow, I've messed the OEL-522 branch and I had to recreate it)