Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-759: Theme the Facts & Figures paragraph type #123

Merged
merged 65 commits into from
Mar 16, 2022
Merged

OEL-759: Theme the Facts & Figures paragraph type #123

merged 65 commits into from
Mar 16, 2022

Conversation

abel-santos-corral
Copy link
Contributor

@abel-santos-corral abel-santos-corral commented Nov 22, 2021

Jira issue(s):

@escuriola escuriola changed the base branch from 1.x to OEL-750-all November 25, 2021 14:53
@escuriola escuriola changed the base branch from OEL-750-all to 1.x November 25, 2021 14:54
Copy link
Contributor

@escuriola escuriola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing also a FactsAndFiguresTest.php in test > src > Kernel > Paragraphs

src/ConfigUtil.php Outdated Show resolved Hide resolved
templates/paragraphs/paragraph--oe-facts-figures.html.twig Outdated Show resolved Hide resolved
src/ConfigUtil.php Outdated Show resolved Hide resolved
tests/src/Functional/ParagraphsTest.php Outdated Show resolved Hide resolved
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to use isEmpty in the entire .module file instead of ??

@drishu drishu changed the title OEL-759: [BCL upgrade][paragraphs] - Facts & Figures OEL-759: Theme the Facts & Figures paragraph type Mar 16, 2022
@donquixote
Copy link
Contributor

Old review comment by Carlos:

Missing also a FactsAndFiguresTest.php in test > src > Kernel > Paragraphs

This seems to be fixed :)

@donquixote donquixote dismissed escuriola’s stale review March 16, 2022 08:58

Requested change was implemented.

@donquixote donquixote merged commit 2494e40 into 1.x Mar 16, 2022
@drishu drishu deleted the OEL-759 branch March 22, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants