-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEL-759: Theme the Facts & Figures paragraph type #123
Conversation
4e3b26a
to
283271d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing also a FactsAndFiguresTest.php in test > src > Kernel > Paragraphs
...graphs/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_variant.yml
Outdated
Show resolved
Hide resolved
...phs/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_disp_icons.yml
Outdated
Show resolved
Hide resolved
...s/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_equal_height.yml
Outdated
Show resolved
Hide resolved
...s/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_grid_columns.yml
Outdated
Show resolved
Hide resolved
...aphs/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_resp_cols.yml
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.module
Outdated
Show resolved
Hide resolved
51fd815
to
95cac7f
Compare
f6f4b6b
to
e964fa7
Compare
...phs/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_disp_icons.yml
Outdated
Show resolved
Hide resolved
...s/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_equal_height.yml
Outdated
Show resolved
Hide resolved
...s/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_grid_columns.yml
Outdated
Show resolved
Hide resolved
...aphs/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_resp_cols.yml
Outdated
Show resolved
Hide resolved
...s/config/install/field.field.paragraph.oe_facts_figures.oe_bt_facts_figures_grid_columns.yml
Outdated
Show resolved
Hide resolved
...p_theme_paragraphs/config/install/field.storage.paragraph.oe_bt_facts_figures_disp_icons.yml
Outdated
Show resolved
Hide resolved
...theme_paragraphs/config/install/field.storage.paragraph.oe_bt_facts_figures_equal_height.yml
Outdated
Show resolved
Hide resolved
...ap_theme_paragraphs/config/install/field.storage.paragraph.oe_bt_facts_figures_resp_cols.yml
Outdated
Show resolved
Hide resolved
...les/oe_bootstrap_theme_paragraphs/config/overrides/field.storage.paragraph.field_oe_icon.yml
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.install
Outdated
Show resolved
Hide resolved
41f6303
to
150317c
Compare
modules/oe_bootstrap_theme_paragraphs/src/EventSubscriber/IconOptionsAlterSubscriber.php
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.install
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.install
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.install
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.install
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.post_update.php
Outdated
Show resolved
Hide resolved
modules/oe_bootstrap_theme_paragraphs/oe_bootstrap_theme_paragraphs.post_update.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to use isEmpty in the entire .module file instead of ??
9f21d73
to
0fe2174
Compare
0fe2174
to
c557773
Compare
8b02568
to
936be66
Compare
Old review comment by Carlos:
This seems to be fixed :) |
Requested change was implemented.
Jira issue(s):