OEL-788: Update local task theming #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
commented
Dec 27, 2021
drishu
commented
Jan 7, 2022
escuriola
previously approved these changes
Jan 7, 2022
| {% if primary %} | ||
| <h2 class="visually-hidden">{{ 'Primary tabs'|t }}</h2> | ||
| {{ _self.menu_local_tasks(primary_links) }} | ||
| {% endif %} |
There was a problem hiding this comment.
Please, consider if a blank line here can add readibility.
| $this->assertCount(1, $active); | ||
| $this->assertEquals('Third link - Active', trim($active->text())); | ||
|
|
||
| // Assert regular link are ordered by weight. |
There was a problem hiding this comment.
Suggested change
| // Assert regular link are ordered by weight. | |
| // Assert regular links are ordered by weight. |
| $html = $this->renderRoot($render); | ||
| $crawler = new Crawler($html); | ||
|
|
||
| $actual = $crawler->filter('nav.nav-tabs'); |
There was a problem hiding this comment.
Please, change name $actual to $nav or $navigation. It makes easier to understand at first glance.
abel-santos-corral
approved these changes
Jan 7, 2022
escuriola
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.